Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make publishNotReadyAddresses configurable in all cases? #685

Closed
avoidik opened this issue Jan 18, 2022 · 3 comments
Closed

Make publishNotReadyAddresses configurable in all cases? #685

avoidik opened this issue Jan 18, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@avoidik
Copy link
Contributor

avoidik commented Jan 18, 2022

Is your feature request related to a problem? Please describe.

With the Kubernetes service discovery enabled I'd like to be able to configure publishNotReadyAddresses on Kubernetes service for Vault server as in example

Describe the solution you'd like

A few more options to be able to set publishNotReadyAddresses, for now only ui is supported

Describe alternatives you've considered

After patch, customized fork

Additional context

N/A
@avoidik avoidik added the enhancement New feature or request label Jan 18, 2022
@avoidik avoidik changed the title Make publishNotReadyAddresses in all cases? Make publishNotReadyAddresses configurable in all cases? Jan 18, 2022
@isaidashev
Copy link

Are you planning to take any action?

@avoidik avoidik mentioned this issue Feb 25, 2022
Merged
@avoidik
Copy link
Contributor Author

avoidik commented Feb 25, 2022 •
edited
Loading

I was self reflecting justifying the real necessity of this feature flag, here is the PR #694

@tomhjp
Copy link
Contributor

tomhjp commented Aug 17, 2022

Released in 0.20.0 🎉

@tomhjp tomhjp closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomhjp @isaidashev @avoidik