fix: add pod labels to the server-test.yaml #1094
Merged
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
|
@vinay-gopalan I am sorry for the tag, but could you please help me merge this PR? |
|
@tvoran could you please take a look at this PR and help me get this moving forward? TIA! |
tvoran
added
vault-server
tvoran
reviewed
Mar 6, 2025
tvoran
added
bug
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
|
@tvoran, thank you for reviewing the changes! I have accepted your suggestions and committed them. Could you please 👍 the PR and help me merge it? Do we need to follow any process to tag the changes? |
tvoran
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change allows one to add labels to the server-test.yaml.
The rationale is that, in our CI pipeline we have a kyverno policy that validates if the required labels are added to the pod manifests. Currently, there is no way to pass extra labels to this template and my change allows to use an existing template to insert pod labels to the server-test pod.
I added unit test to verify the changes
