Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstreamed HCL typexpr package #140

Closed
radeksimko opened this issue Sep 1, 2022 · 0 comments · Fixed by #168
Closed

Use upstreamed HCL typexpr package #140

radeksimko opened this issue Sep 1, 2022 · 0 comments · Fixed by #168
Assignees
@jpogran
Labels
enhancement New feature or request

Comments

@radeksimko
Copy link
Member

radeksimko commented Sep 1, 2022 •
edited
Loading

Background

Currently we use a copy of typeexpr package from Terraform Core which represents Terraform 0.14 - 1.2 as explained in more detail in hashicorp/terraform-ls#917

The v1.2 functionality was upstreamed back to HCL v2.14.0 and Terraform Core switched back to that upstream and removed its own copy of the typeexpr package in hashicorp/terraform#31729

Proposal

As per hashicorp/terraform-ls#917 it is proposed to remove our own typeexpr package and also switch back to the HCL's upstream typeexpr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpogran jpogran

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use upstreamed HCL typexpr package hashicorp/terraform-schema
2 participants
@jpogran @radeksimko