-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs - updated cdn_frontdoor_origin_group
docs to reflect valid health probe intervals
#28143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bubbletroubles the validation for the property still allows values higher than 255, could you update that as well?
terraform-provider-azurerm/internal/services/cdn/cdn_frontdoor_origin_group_resource.go
Lines 114 to 118 in ce28eef
"interval_in_seconds": { | |
Type: pluginsdk.TypeInt, | |
Required: true, | |
ValidateFunc: validation.IntBetween(5, 31536000), | |
}, |
Thanks @stephybun . That's been updated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bubbletroubles LGTM 👍
…lth probe intervals (hashicorp#28143) * Update cdn_frontdoor_origin_group.html.markdown * Update cdn_frontdoor_origin_group.html.markdown * Update cdn_frontdoor_origin_group_resource.go
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Docs - updated
cdn_frontdoor_origin_group
docs to reflect valid health probe intervals. Specifying a value larger than 255 gives the errorPR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
cdn_frontdoor_origin_group
- updated docs to reflect valid values forinterval_in_seconds
property [GH-00000]This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.