r/storage_blob: removing support for defining source_content for Page blobs

In retrospect this doesn't make sense since the content needs to be aligned to a 512-byte boundary
As such it's more likely this'll be used for Block Blobs rather than Page Blobs

Author: tombuildsstuff

azurerm/internal/services/storage/blobs.go

@@ -65,9 +65,8 @@ func (sbu BlobUpload) Create(ctx context.Context) error {
 		if sbu.SourceUri != "" {
 			return sbu.copy(ctx)
 		}
-
 		if sbu.SourceContent != "" {
-			return sbu.uploadPageBlobFromContent(ctx)
+			return fmt.Errorf("`source_content` cannot be specified for a Page blob")
 		}
 		if sbu.Source != "" {
 			return sbu.uploadPageBlob(ctx)
@@ -166,22 +165,6 @@ func (sbu BlobUpload) createEmptyPageBlob(ctx context.Context) error {
 	return nil
 }
 
-func (sbu BlobUpload) uploadPageBlobFromContent(ctx context.Context) error {
-	tmpFile, err := ioutil.TempFile(os.TempDir(), "upload-")
-	if err != nil {
-		return fmt.Errorf("Error creating temporary file: %s", err)
-	}
-	defer os.Remove(tmpFile.Name())
-
-	if _, err = tmpFile.Write([]byte(sbu.SourceContent)); err != nil {
-		return fmt.Errorf("Error writing Source Content to Temp File: %s", err)
-	}
-	defer tmpFile.Close()
-
-	sbu.Source = tmpFile.Name()
-	return sbu.uploadPageBlob(ctx)
-}
-
 func (sbu BlobUpload) uploadPageBlob(ctx context.Context) error {
 	if sbu.Size != 0 {
 		return fmt.Errorf("`size` cannot be set for an uploaded page blob")

azurerm/resource_arm_storage_blob_test.go

@@ -509,33 +509,6 @@ func TestAccAzureRMStorageBlob_pageFromExistingBlob(t *testing.T) {
 	})
 }
 
-func TestAccAzureRMStorageBlob_pageFromInlineContent(t *testing.T) {
-	resourceName := "azurerm_storage_blob.test"
-	ri := tf.AccRandTimeInt()
-	rs := strings.ToLower(acctest.RandString(11))
-	location := testLocation()
-
-	resource.ParallelTest(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
-		CheckDestroy: testCheckAzureRMStorageBlobDestroy,
-		Steps: []resource.TestStep{
-			{
-				Config: testAccAzureRMStorageBlob_pageFromInlineContent(ri, rs, location),
-				Check: resource.ComposeTestCheckFunc(
-					testCheckAzureRMStorageBlobExists(resourceName),
-				),
-			},
-			{
-				ResourceName:            resourceName,
-				ImportState:             true,
-				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"attempts", "parallelism", "size", "source_content", "type"},
-			},
-		},
-	})
-}
-
 func TestAccAzureRMStorageBlob_pageFromLocalFile(t *testing.T) {
 	sourceBlob, err := ioutil.TempFile("", "")
 	if err != nil {
@@ -1136,22 +1109,6 @@ resource "azurerm_storage_blob" "test" {
 `, template)
 }
 
-func testAccAzureRMStorageBlob_pageFromInlineContent(rInt int, rString, location string) string {
-	template := testAccAzureRMStorageBlob_template(rInt, rString, location, "private")
-	return fmt.Sprintf(`
-%s
-
-resource "azurerm_storage_blob" "test" {
-  name                   = "rick.morty"
-  resource_group_name    = "${azurerm_resource_group.test.name}"
-  storage_account_name   = "${azurerm_storage_account.test.name}"
-  storage_container_name = "${azurerm_storage_container.test.name}"
-  type                   = "page"
-  source_content         = "Wubba Lubba Dub Dub"
-}
-`, template)
-}
-
 func testAccAzureRMStorageBlob_pageFromLocalBlob(rInt int, rString, location, fileName string) string {
 	template := testAccAzureRMStorageBlob_template(rInt, rString, location, "private")
 	return fmt.Sprintf(`

website/docs/r/storage_blob.html.markdown

@@ -62,12 +62,12 @@ The following arguments are supported:
 
 * `content_type` - (Optional) The content type of the storage blob. Cannot be defined if `source_uri` is defined. Defaults to `application/octet-stream`.
 
-* `source` - (Optional) An absolute path to a file on the local system. Cannot be specified if `source_content` or `source_uri` is specified.
+* `source` - (Optional) An absolute path to a file on the local system. This field cannot be specified for Append blobs and annot be specified if `source_content` or `source_uri` is specified.
 
-* `source_content` - (Optional) The content for this blob which should be defined inline. Cannot be specified if `source` or `source_uri` is specified.
+* `source_content` - (Optional) The content for this blob which should be defined inline. This field can only be specified for Block blobs and cannot be specified if `source` or `source_uri` is specified.
 
 * `source_uri` - (Optional) The URI of an existing blob, or a file in the Azure File service, to use as the source contents
-    for the blob to be created. Changing this forces a new resource to be created. Cannot be specified if `source` or `source_content` is specified.
+    for the blob to be created. Changing this forces a new resource to be created. This field cannot be specified for Append blobs and cannot be specified if `source` or `source_content` is specified.
 
 * `parallelism` - (Optional) The number of workers per CPU core to run for concurrent uploads. Defaults to `8`.