Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CPU Options in aws_launch_template #6522

Closed
cread opened this issue Nov 19, 2018 · 5 comments · Fixed by #6552
Closed

Support CPU Options in aws_launch_template #6522

cread opened this issue Nov 19, 2018 · 5 comments · Fixed by #6552
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@cread
Copy link

cread commented Nov 19, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please add support for CPU Options to aws_launch_template resource.

New or Affected Resource(s)

  • aws_launch_template

Potential Terraform Configuration

resource "aws_launch_template" "launch" {
  name_prefix = "launch"

  cpu_options {
    core_count = 4
    thread_count = 1
  }
}

References

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Nov 19, 2018
@praveensastry
Copy link
Contributor

@bflad I would like to pick this up ?

@praveensastry
Copy link
Contributor

praveensastry commented Nov 22, 2018

@bflad I have implemented this without any validations for the core_count and threads_per_core fields since the API here doesn't specify any valid value constraints. However the docs here mentions valid values of core_count and threads_per_core per instance type. IMO there shouldn't be any validations at provider level as these values may change from time to time, so i added reference to the AWS docs in the resource module documentation.

@bflad
Copy link
Contributor

bflad commented Feb 12, 2020

Support for the cpu_options configuration block in the aws_launch_template resource has been merged and will release with version 2.49.0 of the Terraform AWS Provider, tomorrow. Thanks to @praveensastry for the implementation. 👍

@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants