Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for aws_security_group_rule in documentation is inconsistent #5640

Closed
drzero42 opened this issue Aug 22, 2018 · 3 comments
Closed

Example for aws_security_group_rule in documentation is inconsistent #5640

drzero42 opened this issue Aug 22, 2018 · 3 comments
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@drzero42
Copy link

The documentation for aws_security_group_rule has the following example:

resource "aws_security_group_rule" "allow_all" {
  type            = "ingress"
  from_port       = 0
  to_port         = 65535
  protocol        = "tcp"
  cidr_blocks     = ["0.0.0.0/0"]
  prefix_list_ids = ["pl-12c4e678"]

  security_group_id = "sg-123456"
}

In the Argument Reference just below it, it says that prefix_list_ids is only valid for egress. In the example the type is ingress, but prefx_list_ids is specified.

This example should probably be modified :)

@bflad bflad added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 26, 2018
@chaspy
Copy link
Contributor

chaspy commented Oct 6, 2019

it says that prefix_list_ids is only valid for egress

Is it true?
I didn't find the fact in the document https://www.terraform.io/docs/providers/aws/r/security_group_rule.html 🤔

@bflad bflad added this to the v2.30.0 milestone Oct 6, 2019
@bflad
Copy link
Contributor

bflad commented Oct 6, 2019

@chaspy thanks for the note -- the documentation was recently updated with #10067.

If there are further documentation feature requests or bug reports, please create a new GitHub issue. 👍

@bflad bflad closed this as completed Oct 6, 2019
@ghost
Copy link

ghost commented Nov 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

No branches or pull requests

3 participants