Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B account region enable #41678

Merged
merged 6 commits into from
Mar 6, 2025
Merged

B account region enable #41678

merged 6 commits into from
Mar 6, 2025

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Mar 5, 2025

Description

Currently, when attempting to enable a region that is already in the enabling or enabled status, an error occurs. This change will prevent this error by allowing the process to skip the EnableRegion API call. Instead, it would go directly to the waitRegionEnabled status if the region is already enabling or enabled. Essentially, this change modifies the behavior by letting the process continue without error/failing.

Relations

Closes #41430

References

Output from Acceptance Testing

> make testacc TESTARGS="-run=TestAccAccount_serial/Region" PKG=account
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial/Region -timeout 360m -vet=off
2025/03/06 10:23:09 Initializing Terraform AWS Provider...
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/Region
=== RUN   TestAccAccount_serial/Region/basic
=== RUN   TestAccAccount_serial/Region/AccountID
    region_test.go:70: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- PASS: TestAccAccount_serial (413.81s)
    --- PASS: TestAccAccount_serial/Region (413.81s)
        --- PASS: TestAccAccount_serial/Region/basic (413.81s)
        --- SKIP: TestAccAccount_serial/Region/AccountID (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    420.625s

...

Copy link

github-actions bot commented Mar 5, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/account Issues and PRs that pertain to the account service. size/S Managed by automation to categorize the size of a PR. labels Mar 5, 2025
@nam054 nam054 marked this pull request as ready for review March 6, 2025 18:40
@nam054 nam054 requested a review from a team as a code owner March 6, 2025 18:40
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nam054 nam054 merged commit 955ae48 into main Mar 6, 2025
33 checks passed
@nam054 nam054 deleted the b-account-region-enable branch March 6, 2025 20:21
Copy link

github-actions bot commented Mar 6, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.90.0 milestone Mar 6, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

This functionality has been released in v5.90.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/account Issues and PRs that pertain to the account service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_account_region errors when attempting to enable a region that it already enabled
2 participants