Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f/ New Resource aws_cloudwatch_contributor_managed_insight_rule #41449

Merged
merged 15 commits into from
Feb 19, 2025
Merged

f/ New Resource aws_cloudwatch_contributor_managed_insight_rule #41449

merged 15 commits into from
Feb 19, 2025
+841 −18

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Feb 18, 2025 •
edited
Loading

Description

New Resource Cloudwatch Contributor Managed Insight Rule

Relations

Closes #17877

References

Output from Acceptance Testing

> make testacc PKG=cloudwatch TESTS=TestAccCloudWatchContributorManagedInsightRule_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchContributorManagedInsightRule_'  -timeout 360m -vet=off
2025/02/19 11:00:42 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudWatchContributorManagedInsightRule_basic
=== PAUSE TestAccCloudWatchContributorManagedInsightRule_basic
=== RUN   TestAccCloudWatchContributorManagedInsightRule_disappears
=== PAUSE TestAccCloudWatchContributorManagedInsightRule_disappears
=== RUN   TestAccCloudWatchContributorManagedInsightRule_tags
=== PAUSE TestAccCloudWatchContributorManagedInsightRule_tags
=== CONT  TestAccCloudWatchContributorManagedInsightRule_basic
=== CONT  TestAccCloudWatchContributorManagedInsightRule_tags
=== CONT  TestAccCloudWatchContributorManagedInsightRule_disappears
--- PASS: TestAccCloudWatchContributorManagedInsightRule_disappears (208.59s)
--- PASS: TestAccCloudWatchContributorManagedInsightRule_tags (210.86s)
--- PASS: TestAccCloudWatchContributorManagedInsightRule_basic (241.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 248.263s

> make testacc PKG=cloudwatch TESTS=TestAccCloudWatchContributorInsightRule_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchContributorInsightRule_'  -timeout 360m -vet=off
2025/02/19 11:13:34 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudWatchContributorInsightRule_tags
=== PAUSE TestAccCloudWatchContributorInsightRule_tags
=== RUN   TestAccCloudWatchContributorInsightRule_tags_null
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_null
=== RUN   TestAccCloudWatchContributorInsightRule_tags_EmptyMap
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_EmptyMap
=== RUN   TestAccCloudWatchContributorInsightRule_tags_AddOnUpdate
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_AddOnUpdate
=== RUN   TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnCreate
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnCreate
=== RUN   TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_providerOnly
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_providerOnly
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nonOverlapping
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_overlapping
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_overlapping
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnCreate
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnCreate
=== RUN   TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccCloudWatchContributorInsightRule_basic
=== PAUSE TestAccCloudWatchContributorInsightRule_basic
=== RUN   TestAccCloudWatchContributorInsightRule_disappears
=== PAUSE TestAccCloudWatchContributorInsightRule_disappears
=== CONT  TestAccCloudWatchContributorInsightRule_tags
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccCloudWatchContributorInsightRule_tags_AddOnUpdate
=== CONT  TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccCloudWatchContributorInsightRule_tags_EmptyMap
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_providerOnly
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nonOverlapping
=== CONT  TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnCreate
=== CONT  TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnCreate
=== CONT  TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccCloudWatchContributorInsightRule_basic
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_overlapping
=== CONT  TestAccCloudWatchContributorInsightRule_disappears
=== CONT  TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccCloudWatchContributorInsightRule_disappears (24.64s)
=== CONT  TestAccCloudWatchContributorInsightRule_tags_null
--- PASS: TestAccCloudWatchContributorInsightRule_basic (30.66s)
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccCloudWatchContributorInsightRule_tags_EmptyMap (55.89s)
=== CONT  TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnCreate (58.99s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_null (44.09s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToResourceOnly (69.27s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Add (70.37s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyResourceTag (74.49s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnCreate (75.77s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullOverlappingResourceTag (45.50s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullNonOverlappingResourceTag (76.24s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Replace (78.61s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Replace (83.84s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_ResourceTag (88.82s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyProviderOnlyTag (33.17s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_AddOnUpdate (89.40s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToProviderOnly (90.87s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Add (91.96s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nonOverlapping (96.16s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_DefaultTag (97.17s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_overlapping (97.87s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags (105.98s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_providerOnly (113.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 120.051s

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 18, 2025
@nam054 nam054 marked this pull request as ready for review February 18, 2025 23:16
@nam054 nam054 requested a review from a team as a code owner February 18, 2025 23:16
@johnsonaj johnsonaj added the new-resource Introduces a new resource. label Feb 19, 2025
johnsonaj
johnsonaj approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=estAccCloudWatchContributorManagedInsightRule_\|TestAccCloudWatchContributorInsightRule_' PKG=cloudwatch

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/cloudwatch/... -v -count 1 -parallel 20  -run=estAccCloudWatchContributorManagedInsightRule_\|TestAccCloudWatchContributorInsightRule_ -timeout 360m -vet=off
2025/02/19 13:22:05 Initializing Terraform AWS Provider...
--- PASS: TestAccCloudWatchContributorInsightRule_disappears (30.43s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_EmptyMap (43.97s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullNonOverlappingResourceTag (44.06s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnCreate (58.58s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyProviderOnlyTag (61.26s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Replace (72.36s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_emptyResourceTag (73.32s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_AddOnUpdate (73.98s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Replace (75.74s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_ComputedTag_OnUpdate_Add (76.05s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnCreate (79.38s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToProviderOnly (86.36s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_DefaultTag (88.14s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_IgnoreTags_Overlap_ResourceTag (92.14s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_updateToResourceOnly (62.62s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_null (35.54s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nullOverlappingResourceTag (34.35s)
--- PASS: TestAccCloudWatchContributorInsightRule_basic (29.21s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_EmptyTag_OnUpdate_Add (101.64s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_providerOnly (119.32s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_nonOverlapping (78.36s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags_DefaultTags_overlapping (79.46s)
--- PASS: TestAccCloudWatchContributorInsightRule_tags (124.54s)
--- PASS: TestAccCloudWatchContributorManagedInsightRule_tags (234.42s)
--- PASS: TestAccCloudWatchContributorManagedInsightRule_basic (243.62s)
--- PASS: TestAccCloudWatchContributorManagedInsightRule_disappears (270.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	277.023s

@nam054 nam054 merged commit 9ef7e20 into main Feb 19, 2025
50 checks passed
@nam054 nam054 deleted the f-cloudwatch_managed_insight_rule branch February 19, 2025 19:46
@github-actions github-actions bot added this to the v5.88.0 milestone Feb 19, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Feb 19, 2025
Update CHANGELOG.md for #41449
728f9b6
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.88.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.88.0
Development

Successfully merging this pull request may close these issues.

Feature request: Cloudwatch Contributor Insights for Cloudwatch logs
2 participants
@nam054 @johnsonaj