Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_glue_partition - storage_descriptor.additional_locations #41434

Conversation

GlennChia
Copy link
Collaborator

Description

Support storage_descriptor.additional_locations for Glue Partition.

Relations

Closes #38925
Relates #37891

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccGluePartition' PKG=glue
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGluePartition -timeout 360m -vet=off
2025/02/18 06:17:53 Initializing Terraform AWS Provider...
=== RUN   TestAccGluePartitionIndex_basic
=== PAUSE TestAccGluePartitionIndex_basic
=== RUN   TestAccGluePartitionIndex_disappears
=== PAUSE TestAccGluePartitionIndex_disappears
=== RUN   TestAccGluePartitionIndex_Disappears_table
=== PAUSE TestAccGluePartitionIndex_Disappears_table
=== RUN   TestAccGluePartitionIndex_Disappears_database
=== PAUSE TestAccGluePartitionIndex_Disappears_database
=== RUN   TestAccGluePartition_basic
=== PAUSE TestAccGluePartition_basic
=== RUN   TestAccGluePartition_multipleValues
=== PAUSE TestAccGluePartition_multipleValues
=== RUN   TestAccGluePartition_parameters
=== PAUSE TestAccGluePartition_parameters
=== RUN   TestAccGluePartition_storageDescriptorBasic
=== PAUSE TestAccGluePartition_storageDescriptorBasic
=== RUN   TestAccGluePartition_storageDescriptorAdditionalLocations
=== PAUSE TestAccGluePartition_storageDescriptorAdditionalLocations
=== RUN   TestAccGluePartition_disappears
=== PAUSE TestAccGluePartition_disappears
=== RUN   TestAccGluePartition_Disappears_table
=== PAUSE TestAccGluePartition_Disappears_table
=== CONT  TestAccGluePartitionIndex_basic
=== CONT  TestAccGluePartition_parameters
=== CONT  TestAccGluePartition_basic
=== CONT  TestAccGluePartitionIndex_Disappears_table
=== CONT  TestAccGluePartition_Disappears_table
=== CONT  TestAccGluePartition_disappears
=== CONT  TestAccGluePartition_storageDescriptorAdditionalLocations
=== CONT  TestAccGluePartition_storageDescriptorBasic
=== CONT  TestAccGluePartition_multipleValues
=== CONT  TestAccGluePartitionIndex_disappears
=== CONT  TestAccGluePartitionIndex_Disappears_database
--- PASS: TestAccGluePartition_Disappears_table (25.52s)
--- PASS: TestAccGluePartition_disappears (25.74s)
--- PASS: TestAccGluePartition_multipleValues (28.95s)
--- PASS: TestAccGluePartition_basic (29.10s)
--- PASS: TestAccGluePartition_storageDescriptorBasic (45.16s)
--- PASS: TestAccGluePartitionIndex_Disappears_database (48.82s)
--- PASS: TestAccGluePartitionIndex_Disappears_table (49.24s)
--- PASS: TestAccGluePartition_parameters (60.61s)
--- PASS: TestAccGluePartition_storageDescriptorAdditionalLocations (62.29s)
--- PASS: TestAccGluePartitionIndex_disappears (74.21s)
--- PASS: TestAccGluePartitionIndex_basic (77.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       77.658s

...

@GlennChia GlennChia requested a review from a team as a code owner February 18, 2025 06:19
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Feb 18, 2025
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Feb 18, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=glue TESTS=TestAccGluePartition_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGluePartition_'  -timeout 360m -vet=off
2025/02/18 11:12:24 Initializing Terraform AWS Provider...

--- PASS: TestAccGluePartition_disappears (19.14s)
--- PASS: TestAccGluePartition_Disappears_table (19.14s)
--- PASS: TestAccGluePartition_multipleValues (21.70s)
--- PASS: TestAccGluePartition_basic (23.32s)
--- PASS: TestAccGluePartition_storageDescriptorBasic (38.36s)
--- PASS: TestAccGluePartition_parameters (41.53s)
--- PASS: TestAccGluePartition_storageDescriptorAdditionalLocations (41.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       49.001s

@jar-b
Copy link
Member

jar-b commented Feb 18, 2025

Thanks for your contribution, @GlennChia! 👍

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b jar-b merged commit d7e5dee into hashicorp:main Feb 18, 2025
44 checks passed
@github-actions github-actions bot added this to the v5.88.0 milestone Feb 18, 2025
@GlennChia GlennChia deleted the f-aws_glue_partition-storage_descriptor-additional_locations branch February 19, 2025 03:22
Copy link

This functionality has been released in v5.88.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error when importing aws_glue_partition
3 participants