Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/redshiftserverless_namespace: add admin_user_password_wo write-only attribute #41412

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

johnsonaj
Copy link
Contributor

Description

add admin_user_password_wo write-only attribute

Relations

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccRedshiftServerlessNamespace_basic\|TestAccRedshiftServerlessNamespace_user\|TestAccRedshiftServerlessNamespace_diappears\|TestAccRedshiftServerlessNamespace_userPasswordWriteOnly" PKG=redshiftserverless

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20  -run=TestAccRedshiftServerlessNamespace_basic\|TestAccRedshiftServerlessNamespace_user\|TestAccRedshiftServerlessNamespace_diappears\|TestAccRedshiftServerlessNamespace_userPasswordWriteOnly -timeout 360m -vet=off
2025/02/15 12:38:23 Initializing Terraform AWS Provider...
=== RUN   TestAccRedshiftServerlessNamespace_basic
=== PAUSE TestAccRedshiftServerlessNamespace_basic
=== RUN   TestAccRedshiftServerlessNamespace_user
=== PAUSE TestAccRedshiftServerlessNamespace_user
=== RUN   TestAccRedshiftServerlessNamespace_userPasswordWriteOnly
=== PAUSE TestAccRedshiftServerlessNamespace_userPasswordWriteOnly
=== CONT  TestAccRedshiftServerlessNamespace_basic
=== CONT  TestAccRedshiftServerlessNamespace_userPasswordWriteOnly
=== CONT  TestAccRedshiftServerlessNamespace_user
--- PASS: TestAccRedshiftServerlessNamespace_userPasswordWriteOnly (20.11s)
--- PASS: TestAccRedshiftServerlessNamespace_user (22.97s)
--- PASS: TestAccRedshiftServerlessNamespace_basic (24.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	30.732s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 15, 2025
@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 15, 2025
@johnsonaj johnsonaj marked this pull request as ready for review February 15, 2025 19:42
@johnsonaj johnsonaj requested a review from a team as a code owner February 15, 2025 19:42
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=redshiftserverless TESTARGS="-run=TestAccRedshiftServerlessNamespace_basic\|TestAccRedshiftServerlessNamespace_user\|TestAccRedshiftServerlessNamespace_disappears\|TestAccRedshiftServerlessNamespace_userPasswordWriteOnly"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20  -run=TestAccRedshiftServerlessNamespace_basic\|TestAccRedshiftServerlessNamespace_user\|TestAccRedshiftServerlessNamespace_disappears\|TestAccRedshiftServerlessNamespace_userPasswordWriteOnly -timeout 360m -vet=off
2025/02/18 15:10:45 Initializing Terraform AWS Provider...

--- PASS: TestAccRedshiftServerlessNamespace_disappears (12.77s)
--- PASS: TestAccRedshiftServerlessNamespace_userPasswordWriteOnly (20.64s)
--- PASS: TestAccRedshiftServerlessNamespace_user (23.31s)
--- PASS: TestAccRedshiftServerlessNamespace_basic (25.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 32.252s

@johnsonaj johnsonaj merged commit 58d0ae6 into main Feb 19, 2025
44 checks passed
@johnsonaj johnsonaj deleted the f-redshiftserverless_namespace_wo branch February 19, 2025 21:34
@github-actions github-actions bot added this to the v5.88.0 milestone Feb 19, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Feb 19, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 20, 2025
Copy link

This functionality has been released in v5.88.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants