-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing on_demand_throughput attrs for aws_dynamodb_table data source #41350
fix: Add missing on_demand_throughput attrs for aws_dynamodb_table data source #41350
Conversation
Community NoteVoting for Prioritization
For Submitters
|
82132d3
to
cb06e54
Compare
cb06e54
to
547d08c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTableDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableDataSource_' -timeout 360m -vet=off
2025/02/12 16:53:23 Initializing Terraform AWS Provider...
--- PASS: TestAccDynamoDBTableDataSource_tags (25.69s)
--- PASS: TestAccDynamoDBTableDataSource_tags_EmptyMap (26.06s)
--- PASS: TestAccDynamoDBTableDataSource_tags_NullMap (26.30s)
--- PASS: TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_DefaultTag (26.30s)
--- PASS: TestAccDynamoDBTableDataSource_tags_DefaultTags_nonOverlapping (26.35s)
--- PASS: TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_ResourceTag (26.71s)
--- PASS: TestAccDynamoDBTableDataSource_basic (31.54s)
--- PASS: TestAccDynamoDBTableDataSource_onDemandThroughput (44.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb 51.422s
Thanks for the fix, @acwwat! 👍 |
This functionality has been released in v5.87.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR is to add the missing
on_demand_throughput
configuration block to the resource root and theglobal_secondary_index
configuration block in theaws_dynamodb_table
resource.Relations
Closes #41343
Relates #37799
References
n/a
Output from Acceptance Testing