Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing on_demand_throughput attrs for aws_dynamodb_table data source #41350

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Feb 12, 2025

Description

This PR is to add the missing on_demand_throughput configuration block to the resource root and the global_secondary_index configuration block in the aws_dynamodb_table resource.

Relations

Closes #41343
Relates #37799

References

n/a

Output from Acceptance Testing

$ make testacc TESTS=TestAccDynamoDBTableDataSource_ PKG=dynamodb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableDataSource_'  -timeout 360m -vet=off
2025/02/11 23:25:48 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableDataSource_tags
=== PAUSE TestAccDynamoDBTableDataSource_tags
=== RUN   TestAccDynamoDBTableDataSource_tags_NullMap
=== PAUSE TestAccDynamoDBTableDataSource_tags_NullMap
=== RUN   TestAccDynamoDBTableDataSource_tags_EmptyMap
=== PAUSE TestAccDynamoDBTableDataSource_tags_EmptyMap
=== RUN   TestAccDynamoDBTableDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccDynamoDBTableDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccDynamoDBTableDataSource_basic
=== PAUSE TestAccDynamoDBTableDataSource_basic
=== RUN   TestAccDynamoDBTableDataSource_onDemandThroughput
=== PAUSE TestAccDynamoDBTableDataSource_onDemandThroughput
=== CONT  TestAccDynamoDBTableDataSource_tags
=== CONT  TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccDynamoDBTableDataSource_tags_NullMap
=== CONT  TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccDynamoDBTableDataSource_tags_DefaultTags_nonOverlapping
=== CONT  TestAccDynamoDBTableDataSource_basic
=== CONT  TestAccDynamoDBTableDataSource_onDemandThroughput
=== CONT  TestAccDynamoDBTableDataSource_tags_EmptyMap
--- PASS: TestAccDynamoDBTableDataSource_tags_NullMap (28.21s)
--- PASS: TestAccDynamoDBTableDataSource_tags_EmptyMap (28.26s)
--- PASS: TestAccDynamoDBTableDataSource_tags (29.94s)
--- PASS: TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_DefaultTag (30.33s)
--- PASS: TestAccDynamoDBTableDataSource_tags_DefaultTags_nonOverlapping (30.38s)
--- PASS: TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_ResourceTag (34.82s)
--- PASS: TestAccDynamoDBTableDataSource_basic (35.70s)
--- PASS: TestAccDynamoDBTableDataSource_onDemandThroughput (44.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   44.286s

$

@acwwat acwwat requested a review from a team as a code owner February 12, 2025 04:29
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dynamodb Issues and PRs that pertain to the dynamodb service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Feb 12, 2025
@acwwat acwwat force-pushed the b-aws_dynamodb_table-add_missing_on_demand_throughput_attrs branch from 82132d3 to cb06e54 Compare February 12, 2025 04:31
@acwwat acwwat force-pushed the b-aws_dynamodb_table-add_missing_on_demand_throughput_attrs branch from cb06e54 to 547d08c Compare February 12, 2025 04:34
@jar-b jar-b added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2025
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 12, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTableDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableDataSource_'  -timeout 360m -vet=off
2025/02/12 16:53:23 Initializing Terraform AWS Provider...

--- PASS: TestAccDynamoDBTableDataSource_tags (25.69s)
--- PASS: TestAccDynamoDBTableDataSource_tags_EmptyMap (26.06s)
--- PASS: TestAccDynamoDBTableDataSource_tags_NullMap (26.30s)
--- PASS: TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_DefaultTag (26.30s)
--- PASS: TestAccDynamoDBTableDataSource_tags_DefaultTags_nonOverlapping (26.35s)
--- PASS: TestAccDynamoDBTableDataSource_tags_IgnoreTags_Overlap_ResourceTag (26.71s)
--- PASS: TestAccDynamoDBTableDataSource_basic (31.54s)
--- PASS: TestAccDynamoDBTableDataSource_onDemandThroughput (44.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   51.422s

@jar-b
Copy link
Member

jar-b commented Feb 12, 2025

Thanks for the fix, @acwwat! 👍

@jar-b jar-b merged commit 2cb81dd into hashicorp:main Feb 12, 2025
63 checks passed
@github-actions github-actions bot added this to the v5.87.0 milestone Feb 12, 2025
Copy link

This functionality has been released in v5.87.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. external-maintainer Contribution from a trusted external contributor. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants