Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kms: add support for external key store #40557

Merged
merged 22 commits into from
Jan 13, 2025
Merged

kms: add support for external key store #40557

merged 22 commits into from
Jan 13, 2025

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Dec 13, 2024 •
edited
Loading

Closes #28092

  • Adds XKS (External Key Store) arguments to the aws_kms_custom_key_store resource
  • Changes CloudHSM related arguments from Required to Optional.
  • Updates documentation with CloudHSM and XKS (public and private) examples.

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/kms Issues and PRs that pertain to the kms service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Dec 13, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 13, 2024
@bschaatsbergen bschaatsbergen marked this pull request as ready for review December 13, 2024 12:23
@bschaatsbergen bschaatsbergen requested a review from a team as a code owner December 13, 2024 12:23
@bschaatsbergen bschaatsbergen removed the external-maintainer Contribution from a trusted external contributor. label Dec 13, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 13, 2024
@github-actions github-actions bot added the external-maintainer Contribution from a trusted external contributor. label Dec 13, 2024
@jar-b jar-b self-assigned this Jan 10, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 10, 2025
@jar-b
r/aws_kms_custom_key_store: trust_anchor_certificate is now optional
069e6ea 
This argument is now only required if `custom_key_store_type` is `AWS_CLOUDHSM`.
jar-b added 4 commits January 13, 2025 10:05
@jar-b
r/aws_kms_custom_key_store: remove `xks_proxy_authentication_credenti…
fa301ab 
…al` flattener

Removes the flattener for `xks_proxy_authentication_credential` given only one of the two nested arguments is returned from the AWS API. This was done as a precaution to eliminate potential failure modes in writing the returned value given we cannot acceptance test these changes. If drift detection on the nested `access_key_id` argument is desired by the community, it will be added in a future release.
@jar-b
r/aws_kms_custom_key_store(test): tidy serial test structure
a80b55e
@jar-b
Merge branch 'main' into f/external-kms-store
2f3d6a8
@jar-b
chore: make fix-constants
53bce24
jar-b
jar-b approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Community Note: Due to the dependency on an external key store, we are unable to acceptance test the changes made in this pull request. Any community feedback in testing these new arguments would be greatly appreciated!

@jar-b
Copy link
Member

jar-b commented Jan 13, 2025

Thanks for your contribution, @bschaatsbergen! 👍

@jar-b jar-b merged commit 243256b into hashicorp:main Jan 13, 2025
47 checks passed
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 13, 2025
@bschaatsbergen bschaatsbergen deleted the f/external-kms-store branch January 13, 2025 20:48
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 16, 2025
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.84.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

@YakDriver YakDriver YakDriver approved these changes

Assignees

@jar-b jar-b

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/kms Issues and PRs that pertain to the kms service.
Projects
None yet
Milestone
v5.84.0
Development

Successfully merging this pull request may close these issues.

AWS KMS External Key Store
4 participants
@bschaatsbergen @jar-b @YakDriver @justinretzolk