Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_verifiedaccess_endpoint set PolicyEnabled based on policy_document #38675

Conversation

Dansyuqri
Copy link
Contributor

Description

Update aws_verifiedaccess_endpoint to set PolicyEnabled flag based on policy_document content

Relations

Closes #38609

References

Output from Acceptance Testing

% make testacc TESTS=TestAccVerifiedAccess_serial/Endpoint_policyDocument PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVerifiedAccess_serial/Endpoint_policyDocument'  -timeout 360m
=== RUN   TestAccVerifiedAccess_serial
=== PAUSE TestAccVerifiedAccess_serial
=== CONT  TestAccVerifiedAccess_serial
=== RUN   TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/Endpoint_policyDocument
--- PASS: TestAccVerifiedAccess_serial (0.16s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1304.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1308.218s

@Dansyuqri Dansyuqri requested a review from a team as a code owner August 3, 2024 07:09
Copy link

github-actions bot commented Aug 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. needs-triage Waiting for first response or review from a maintainer. labels Aug 3, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Dansyuqri 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 6, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedAccess_serial/Endpoint_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVerifiedAccess_serial/Endpoint_ -timeout 360m
=== RUN   TestAccVerifiedAccess_serial
=== PAUSE TestAccVerifiedAccess_serial
=== CONT  TestAccVerifiedAccess_serial
=== RUN   TestAccVerifiedAccess_serial/Endpoint_basic
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_basic
=== RUN   TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== RUN   TestAccVerifiedAccess_serial/Endpoint_tags
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_tags
=== RUN   TestAccVerifiedAccess_serial/Endpoint_disappears
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/Endpoint_basic
=== CONT  TestAccVerifiedAccess_serial/Endpoint_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_tags
=== CONT  TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== CONT  TestAccVerifiedAccess_serial/Endpoint_policyDocument
--- PASS: TestAccVerifiedAccess_serial (0.44s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1168.58s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1209.00s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1296.85s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1344.17s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1541.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1547.303s

@ewbankkit
Copy link
Contributor

@Dansyuqri Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6f6d44c into hashicorp:main Aug 28, 2024
32 of 33 checks passed
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 28, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for policy_enabled for aws_verifiedaccess_endpoint resource
3 participants