Fix issue #29791

[robmoss2k]

Description

Adds AWAITING_APP_CNAME to the pending state for awaiting domain association verification and the target state for awaiting domain association creation.

Relations

Closes #29791

References

Output from Acceptance Testing

I'm on Windows. I couldn't get the tests to work. In WSL, I ran out of memory while trying to run it. If someone could run this, that would be excellent.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @robmoss2k 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[MrLightful]

There's also a IMPORTING_CUSTOM_CERTIFICATE

Error: waiting for Amplify Domain Association (***/dizconto.com) create: unexpected state 
'IMPORTING_CUSTOM_CERTIFICATE', wanted target 'PENDING_VERIFICATION, PENDING_DEPLOYMENT, AVAILABLE'. 
last error: %!s(<nil>)

[robmoss2k]

@romatallinn Added that to the draft PR, thanks. Still no idea how to get hold of someone capable of running the tests. I just tried and failed again.

[MrLightful]

Thanks. Can you drop docs on what tests exactly you need to run? I don't see them in contribution guides, besides the ones run automatically in CI. I'll see what I can do.

[MrLightful]

Yikes, found the aforementioned tests. Quite bulky to setup.

@robmoss2k can you mark MR as non-draft, maybe this will help a bit with visibility.

Guide: Raising a pull request

Once you believe your pull request is ready to be reviewed, ensure the pull request is not a draft pull request by marking it ready for review or removing [WIP] from the pull request title if necessary, and a maintainer will review it. Follow the checklists below to help ensure that your contribution can be easily reviewed and potentially merged.

[robmoss2k]

Marked as ready for review - thanks for the help, @romatallinn!

[davad]

Not sure if this was helpful or not, but I pulled the branch and ran tests. My team is also dealing with this bug.

I followed these steps in a fresh VM. Like @MrLightful said, it was pretty bulky to set up. I ran make build and make test. I did not run make testacc.

Running make build and make test was successful.

What else needs to be done to verify and merge this PR?

[gdavison]

Thanks for the PR, @robmoss2k. I've rebased it to bring it up to date with the current codebase and added a test that triggered the error before your fix.

Acceptance test results

$ make testacc PKG=amplify TESTS='TestAccAmplify_serial/DomainAssociation'

--- PASS: TestAccAmplify_serial (4709.73s)
    --- PASS: TestAccAmplify_serial/DomainAssociation (4709.73s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/disappears (296.49s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/update (702.05s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/createWithSubdomain (673.31s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/basic (299.43s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/certificateSettings_Managed (1110.73s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/certificateSettings_Custom (1627.71s)

[github-actions]

This functionality has been released in v5.88.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[robmoss2k]

Thanks, @gdavison!