Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Updating the description of a Private or Public DNS Namespace causes resource to be replaced #32341

Closed
pierskarsenbarg opened this issue Jul 3, 2023 · 3 comments · Fixed by #32342
Labels
bug Addresses a defect in current functionality. service/servicediscovery Issues and PRs that pertain to the servicediscovery service.
Milestone

Comments

@pierskarsenbarg
Copy link
Contributor

pierskarsenbarg commented Jul 3, 2023

Terraform Core Version

1.5.2

AWS Provider Version

5.6.2

Affected Resource(s)

  • aws_service_discovery_private_dns_namespace
  • aws_service_discovery_public_dns_namespace

Expected Behavior

When changing the description, only the description should be changed - it shouldn't require a replacement

Actual Behavior

A change in description causes the resource to be replaced

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

provider "aws" {
  region = "eu-west-1"
}

resource "aws_vpc" "example" {
  cidr_block = "10.0.0.0/16"
}

resource "aws_service_discovery_private_dns_namespace" "example" {
  name        = "hoge.example.local"
  description = "example"
  vpc         = aws_vpc.example.id
}

Then change the description to something different (for example, "example2") and run terraform plan

Steps to Reproduce

  1. Run the above code
  2. Change the description text from example to example2
  3. Either run terraform apply or terraform plan to see the replacement details

Debug Output

No response

Panic Output

No response

Important Factoids

I've tested this both in the console and with the AWS CLI and neither causes the namespace to be recreated.

References

No response

Would you like to implement a fix?

Yes

@pierskarsenbarg pierskarsenbarg added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jul 3, 2023
@github-actions github-actions bot added service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/vpc Issues and PRs that pertain to the vpc service. labels Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@pierskarsenbarg pierskarsenbarg changed the title [Bug]: Updating the description of a Private DNS Namespace causes resource to be replaced [Bug]: Updating the description of a Private or Public DNS Namespace causes resource to be replaced Jul 3, 2023
@ewbankkit ewbankkit removed needs-triage Waiting for first response or review from a maintainer. service/vpc Issues and PRs that pertain to the vpc service. labels Jul 3, 2023
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/servicediscovery Issues and PRs that pertain to the servicediscovery service.
Projects
None yet
2 participants