Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add budget datasource to resource budget #31691

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Add budget datasource to resource budget #31691

merged 1 commit into from
Jun 6, 2023

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented May 31, 2023 •
edited
Loading

Description

Add budget data source to resource budget

Output from Acceptance Testing

> make testacc TESTARGS='-run=TestAccBudgetsBudgetDataSource_basic' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudgetDataSource_basic -timeout 180m
=== RUN   TestAccBudgetsBudgetDataSource_basic
=== PAUSE TestAccBudgetsBudgetDataSource_basic
=== CONT  TestAccBudgetsBudgetDataSource_basic
--- PASS: TestAccBudgetsBudgetDataSource_basic (12.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    15.523s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/budgets Issues and PRs that pertain to the budgets service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels May 31, 2023
@nam054 nam054 force-pushed the f-aws-budgets-ds branch 3 times, most recently from 6ee6f10 to bd99c6e Compare May 31, 2023 22:54
@github-actions github-actions bot added the generators Relates to code generators. label May 31, 2023
@nam054 nam054 force-pushed the f-aws-budgets-ds branch 2 times, most recently from 7071a19 to f846c1a Compare June 1, 2023 17:22
@nam054 nam054 marked this pull request as ready for review June 1, 2023 17:41
@nam054 nam054 force-pushed the f-aws-budgets-ds branch from f846c1a to 26f74ea Compare June 1, 2023 22:20
jar-b
jar-b reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just a couple suggestions on required attributes.

@nam054 nam054 force-pushed the f-aws-budgets-ds branch 3 times, most recently from 45dddfb to eeb6f15 Compare June 5, 2023 19:22
jar-b
jar-b reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple minor suggestions.

$ make testacc TESTARGS='-run=TestAccBudgetsBudgetDataSource_basic' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudgetDataSource_basic -timeout 180m
=== RUN   TestAccBudgetsBudgetDataSource_basic
=== PAUSE TestAccBudgetsBudgetDataSource_basic
=== CONT  TestAccBudgetsBudgetDataSource_basic
--- PASS: TestAccBudgetsBudgetDataSource_basic (19.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    23.109s

@nam054 nam054 force-pushed the f-aws-budgets-ds branch from eeb6f15 to bd2fba9 Compare June 5, 2023 20:09
jar-b
jar-b reviewed Jun 5, 2023
View reviewed changes
@nam054 nam054 force-pushed the f-aws-budgets-ds branch from bd2fba9 to 0b1b69a Compare June 5, 2023 21:04
jar-b
jar-b approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=budgets TESTS=TestAccBudgetsBudgetDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20 -run='TestAccBudgetsBudgetDataSource_'  -timeout 180m
=== RUN   TestAccBudgetsBudgetDataSource_basic
=== PAUSE TestAccBudgetsBudgetDataSource_basic
=== CONT  TestAccBudgetsBudgetDataSource_basic
--- PASS: TestAccBudgetsBudgetDataSource_basic (13.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    17.122s

@nam054 nam054 merged commit ad2752d into main Jun 6, 2023
@nam054 nam054 deleted the f-aws-budgets-ds branch June 6, 2023 17:04
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 6, 2023
github-actions bot pushed a commit that referenced this pull request Jun 6, 2023
Update CHANGELOG.md for #31691
2ff917a
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/budgets Issues and PRs that pertain to the budgets service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nam054 @jar-b