[Bug]: Redshift data source crashes after redshift is re-created with same name/id
#31407
Labels
bug
Addresses a defect in current functionality.
crash
Results from or addresses a Terraform crash or kernel panic.
service/redshift
Issues and PRs that pertain to the redshift service.
Comments
sklirg
added
bug
Community NoteVoting for Prioritization
Volunteering to Work on This Issue
|
github-actions
bot
added
crash
sklirg
changed the title
data source crashes after redshift is re-created with same name/id
justinretzolk
removed
the
needs-triage
|
This issue resolved itself after the redshift cluster went out of "modifying"-state. So this might be an issue only happening during cluster modification. Our cluster was "modifying" for a long time, probably due to restoration from backup after the recreate, which rendered our state unusable for this time, so I still think this should be looked into. |
|
Need to add: if rsc.Endpoint != nil |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Terraform Core Version
1.4.6
AWS Provider Version
4.66.1,4.65.0
Affected Resource(s)
Expected Behavior
Refresh and plan should not crash when looking up a resource through a data source
Actual Behavior
terraform refreshandterraform planproduce this crash:Stack trace from the terraform-provider-aws_v4.66.1_x5 plugin: panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x10b14ae54] goroutine 829 [running]: github.com/hashicorp/terraform-provider-aws/internal/service/redshift.dataSourceClusterRead({0x10ff06ae0, 0x14005c731a0}, 0x14005b5af00, {0x10fdad600?, 0x14000286c00}) github.com/hashicorp/terraform-provider-aws/internal/service/redshift/cluster_data_source.go:285 +0xb74 github.com/hashicorp/terraform-provider-aws/internal/provider.interceptedHandler[...].func1(0x0?, {0x10fdad600?, 0x14000286c00?}) github.com/hashicorp/terraform-provider-aws/internal/provider/intercept.go:95 +0x118 github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x10ff06ae0?, {0x10ff06ae0?, 0x14005c5bcb0?}, 0xd?, {0x10fdad600?, 0x14000286c00?}) github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource.go:719 +0x64 github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0x140019b21c0, {0x10ff06ae0, 0x14005c5bcb0}, 0x14005b5ae00, {0x10fdad600, 0x14000286c00}) github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource.go:943 +0x118 github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0x14001c81770, {0x10ff06ae0?, 0x14005c5bb90?}, 0x14004521960) github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/grpc_provider.go:1195 +0x304 github.com/hashicorp/terraform-plugin-mux/tf5muxserver.muxServer.ReadDataSource({0x14002a91110, 0x14002a914d0, {0x14005011ea0, 0x2, 0x2}, {0x0, 0x0, 0x0}, {0x0, 0x0, ...}, ...}, ...) github.com/hashicorp/terraform-plugin-mux@v0.10.0/tf5muxserver/mux_server_ReadDataSource.go:27 +0xdc github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadDataSource(0x140024fe280, {0x10ff06ae0?, 0x14005c5b0b0?}, 0x14002e27bd0) github.com/hashicorp/terraform-plugin-go@v0.15.0/tfprotov5/tf5server/server.go:658 +0x368 github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler({0x10fa9ade0?, 0x140024fe280}, {0x10ff06ae0, 0x14005c5b0b0}, 0x14005b72ee0, 0x0) github.com/hashicorp/terraform-plugin-go@v0.15.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:455 +0x170 google.golang.org/grpc.(*Server).processUnaryRPC(0x14004a32780, {0x10ff16fc0, 0x14000b64680}, 0x14005c66120, 0x140051318c0, 0x1169d61d0, 0x0) google.golang.org/grpc@v1.54.0/server.go:1345 +0xc64 google.golang.org/grpc.(*Server).handleStream(0x14004a32780, {0x10ff16fc0, 0x14000b64680}, 0x14005c66120, 0x0) google.golang.org/grpc@v1.54.0/server.go:1722 +0x82c google.golang.org/grpc.(*Server).serveStreams.func1.2() google.golang.org/grpc@v1.54.0/server.go:966 +0x84 created by google.golang.org/grpc.(*Server).serveStreams.func1 google.golang.org/grpc@v1.54.0/server.go:964 +0x290 Error: The terraform-provider-aws_v4.66.1_x5 plugin crashed! This is always indicative of a bug within the plugin. It would be immensely helpful if you could report the crash with the plugin's maintainers so that it can be fixed. The output above should help diagnose the issue.Removing the following data lookup stops the crash:
Relevant Error/Panic Output Snippet
Terraform Configuration Files
Steps to Reproduce
Debug Output
Panic Output
Important Factoids
As mentioned in the steps to reproduce, this redshift-cluster has been recreated with the same ID as before. This worked fine prior to the recreation, but after, it started crashing. The error occurred in a "live" terraform environment, but I managed to replicate it in a minimally reproducible environment (completely clean, no existing state), as attached.
Currently, the redshift cluster is shown as in "modifying" Status in the AWS Console.
References
No response
Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered: