Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS cluster instance group parameter name has no drift detection #30245

Open
jar-b opened this issue Mar 24, 2023 · 2 comments
Open

RDS cluster instance group parameter name has no drift detection #30245

jar-b opened this issue Mar 24, 2023 · 2 comments
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service.

Comments

@jar-b
Copy link
Member

jar-b commented Mar 24, 2023

Description

The DBInstanceParameterGroupName field only appears in ModifyDBCluster, but not CreateDBCluster or DescribeDBClusters.

The current APIs pose potential problems for Terraform users:

  1. This value can't be set on create. If provided in a Terraform configuration, users would likely assume that the cluster is created with the designated instance parameter group name. In reality, this only gets set if the resource is subsequently modified.
  2. This value can't be read once set. DescribeDBClusters does not include DBInstanceParameterGroupName in the response, so there is no way to detect when changes are made outside of Terraform (ie. via the AWS CLI or console). This prevents customers from verifying their infrastructure is continuously configured as intended.

I've opened a support case with AWS for confirmation that this field is intended to be sent during modification of an existing cluster only. Ideally these fields would be exposed in the Create input and Describe output structs for consistency, providing the ability to properly detect drift. However, given the current state we should send the db_instance_parameter_group_name attribute:

  • Any time the value changes (existing behavior)
  • Any time it is set in configuration (new behavior)

The new behavior prevents cases where the remote value has changed and the inability to read the existing value causes this parameter to be (incorrectly) omitted. Drift still cannot be detected on this attribute, but by always sending the value when set we at least ensure that the desired configuration is sent every time a modification is made.

References

Would you like to implement a fix?

None

@jar-b jar-b added bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. labels Mar 24, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Mar 13, 2025
@jar-b jar-b removed the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

No branches or pull requests

1 participant