Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_identitystore_(group|user): Restore use of List API calls when filter is specified #28937

Merged
merged 6 commits into from
Jan 17, 2023
Merged

d/aws_identitystore_(group|user): Restore use of List API calls when filter is specified #28937

merged 6 commits into from
Jan 17, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Restores use of the ListGroups and ListUsers APIs when filter is specified with the aws_identitystore_group and aws_identitystore_user data sources.

Relations

Closes #28139.
Closes #27830.
Relates #27762.
Relates #27053.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccIdentityStoreUserDataSource_' PKG=identitystore ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 3  -run=TestAccIdentityStoreUserDataSource_ -timeout 180m
=== RUN   TestAccIdentityStoreUserDataSource_basic
=== PAUSE TestAccIdentityStoreUserDataSource_basic
=== RUN   TestAccIdentityStoreUserDataSource_filterUserName
=== PAUSE TestAccIdentityStoreUserDataSource_filterUserName
=== RUN   TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== PAUSE TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== RUN   TestAccIdentityStoreUserDataSource_email
=== PAUSE TestAccIdentityStoreUserDataSource_email
=== RUN   TestAccIdentityStoreUserDataSource_userID
=== PAUSE TestAccIdentityStoreUserDataSource_userID
=== RUN   TestAccIdentityStoreUserDataSource_nonExistent
=== PAUSE TestAccIdentityStoreUserDataSource_nonExistent
=== RUN   TestAccIdentityStoreUserDataSource_userIdFilterMismatch
=== PAUSE TestAccIdentityStoreUserDataSource_userIdFilterMismatch
=== RUN   TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
=== PAUSE TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
=== RUN   TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
=== PAUSE TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
=== CONT  TestAccIdentityStoreUserDataSource_basic
=== CONT  TestAccIdentityStoreUserDataSource_nonExistent
=== CONT  TestAccIdentityStoreUserDataSource_email
--- PASS: TestAccIdentityStoreUserDataSource_nonExistent (4.63s)
=== CONT  TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
--- PASS: TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId (9.63s)
=== CONT  TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
--- PASS: TestAccIdentityStoreUserDataSource_basic (19.32s)
=== CONT  TestAccIdentityStoreUserDataSource_userID
--- PASS: TestAccIdentityStoreUserDataSource_email (20.24s)
=== CONT  TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== CONT  TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
--- PASS: TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute (1.56s)
--- PASS: TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId (9.46s)
=== CONT  TestAccIdentityStoreUserDataSource_filterUserName
--- PASS: TestAccIdentityStoreUserDataSource_userID (17.71s)
=== CONT  TestAccIdentityStoreUserDataSource_userIdFilterMismatch
--- PASS: TestAccIdentityStoreUserDataSource_uniqueAttributeUserName (18.37s)
--- PASS: TestAccIdentityStoreUserDataSource_filterUserName (17.62s)
--- PASS: TestAccIdentityStoreUserDataSource_userIdFilterMismatch (9.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	52.104s
% make testacc TESTARGS='-run=TestAccIdentityStoreUser_' PKG=identitystore ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 3  -run=TestAccIdentityStoreUser_ -timeout 180m
=== RUN   TestAccIdentityStoreUser_basic
=== PAUSE TestAccIdentityStoreUser_basic
=== RUN   TestAccIdentityStoreUser_disappears
=== PAUSE TestAccIdentityStoreUser_disappears
=== RUN   TestAccIdentityStoreUser_Addresses
=== PAUSE TestAccIdentityStoreUser_Addresses
=== RUN   TestAccIdentityStoreUser_Emails
=== PAUSE TestAccIdentityStoreUser_Emails
=== RUN   TestAccIdentityStoreUser_Locale
=== PAUSE TestAccIdentityStoreUser_Locale
=== RUN   TestAccIdentityStoreUser_NameFamilyName
=== PAUSE TestAccIdentityStoreUser_NameFamilyName
=== RUN   TestAccIdentityStoreUser_NameFormatted
=== PAUSE TestAccIdentityStoreUser_NameFormatted
=== RUN   TestAccIdentityStoreUser_NameGivenName
=== PAUSE TestAccIdentityStoreUser_NameGivenName
=== RUN   TestAccIdentityStoreUser_NameHonorificPrefix
=== PAUSE TestAccIdentityStoreUser_NameHonorificPrefix
=== RUN   TestAccIdentityStoreUser_NameHonorificSuffix
=== PAUSE TestAccIdentityStoreUser_NameHonorificSuffix
=== RUN   TestAccIdentityStoreUser_NameMiddleName
=== PAUSE TestAccIdentityStoreUser_NameMiddleName
=== RUN   TestAccIdentityStoreUser_NickName
=== PAUSE TestAccIdentityStoreUser_NickName
=== RUN   TestAccIdentityStoreUser_PhoneNumbers
=== PAUSE TestAccIdentityStoreUser_PhoneNumbers
=== RUN   TestAccIdentityStoreUser_PreferredLanguage
=== PAUSE TestAccIdentityStoreUser_PreferredLanguage
=== RUN   TestAccIdentityStoreUser_ProfileURL
=== PAUSE TestAccIdentityStoreUser_ProfileURL
=== RUN   TestAccIdentityStoreUser_Timezone
=== PAUSE TestAccIdentityStoreUser_Timezone
=== RUN   TestAccIdentityStoreUser_Title
=== PAUSE TestAccIdentityStoreUser_Title
=== RUN   TestAccIdentityStoreUser_UserType
=== PAUSE TestAccIdentityStoreUser_UserType
=== CONT  TestAccIdentityStoreUser_basic
=== CONT  TestAccIdentityStoreUser_NickName
=== CONT  TestAccIdentityStoreUser_Timezone
--- PASS: TestAccIdentityStoreUser_basic (20.96s)
=== CONT  TestAccIdentityStoreUser_UserType
--- PASS: TestAccIdentityStoreUser_NickName (50.48s)
=== CONT  TestAccIdentityStoreUser_Title
--- PASS: TestAccIdentityStoreUser_Timezone (51.28s)
=== CONT  TestAccIdentityStoreUser_PreferredLanguage
--- PASS: TestAccIdentityStoreUser_UserType (48.66s)
=== CONT  TestAccIdentityStoreUser_ProfileURL
--- PASS: TestAccIdentityStoreUser_Title (49.03s)
=== CONT  TestAccIdentityStoreUser_PhoneNumbers
--- PASS: TestAccIdentityStoreUser_PreferredLanguage (49.54s)
=== CONT  TestAccIdentityStoreUser_NameHonorificSuffix
--- PASS: TestAccIdentityStoreUser_ProfileURL (50.08s)
=== CONT  TestAccIdentityStoreUser_NameMiddleName
--- PASS: TestAccIdentityStoreUser_NameHonorificSuffix (47.67s)
=== CONT  TestAccIdentityStoreUser_Emails
--- PASS: TestAccIdentityStoreUser_PhoneNumbers (67.63s)
=== CONT  TestAccIdentityStoreUser_NameFamilyName
--- PASS: TestAccIdentityStoreUser_NameMiddleName (49.21s)
=== CONT  TestAccIdentityStoreUser_Locale
--- PASS: TestAccIdentityStoreUser_NameFamilyName (35.81s)
=== CONT  TestAccIdentityStoreUser_Addresses
--- PASS: TestAccIdentityStoreUser_Emails (72.48s)
=== CONT  TestAccIdentityStoreUser_NameFormatted
--- PASS: TestAccIdentityStoreUser_Locale (52.44s)
=== CONT  TestAccIdentityStoreUser_NameHonorificPrefix
--- PASS: TestAccIdentityStoreUser_NameHonorificPrefix (35.72s)
=== CONT  TestAccIdentityStoreUser_NameGivenName
--- PASS: TestAccIdentityStoreUser_NameFormatted (55.32s)
=== CONT  TestAccIdentityStoreUser_disappears
--- PASS: TestAccIdentityStoreUser_Addresses (76.54s)
--- PASS: TestAccIdentityStoreUser_disappears (15.51s)
--- PASS: TestAccIdentityStoreUser_NameGivenName (35.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	297.802s
% make testacc TESTARGS='-run=TestAccIdentityStoreGroupDataSource_' PKG=identitystore ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 3  -run=TestAccIdentityStoreGroupDataSource_ -timeout 180m
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupId
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupId
=== RUN   TestAccIdentityStoreGroupDataSource_nonExistent
=== PAUSE TestAccIdentityStoreGroupDataSource_nonExistent
=== RUN   TestAccIdentityStoreGroupDataSource_groupIdFilterMismatch
=== PAUSE TestAccIdentityStoreGroupDataSource_groupIdFilterMismatch
=== RUN   TestAccIdentityStoreGroupDataSource_externalIdConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreGroupDataSource_externalIdConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreGroupDataSource_filterConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreGroupDataSource_filterConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreGroupDataSource_groupIdConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreGroupDataSource_groupIdConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreGroupDataSource_filterConflictsWithExternalId
=== PAUSE TestAccIdentityStoreGroupDataSource_filterConflictsWithExternalId
=== RUN   TestAccIdentityStoreGroupDataSource_groupIdConflictsWithExternalId
=== PAUSE TestAccIdentityStoreGroupDataSource_groupIdConflictsWithExternalId
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayName
=== CONT  TestAccIdentityStoreGroupDataSource_externalIdConflictsWithUniqueAttribute
=== CONT  TestAccIdentityStoreGroupDataSource_nonExistent
--- PASS: TestAccIdentityStoreGroupDataSource_externalIdConflictsWithUniqueAttribute (2.85s)
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupId
--- PASS: TestAccIdentityStoreGroupDataSource_nonExistent (4.36s)
=== CONT  TestAccIdentityStoreGroupDataSource_filterConflictsWithExternalId
--- PASS: TestAccIdentityStoreGroupDataSource_filterConflictsWithExternalId (1.72s)
=== CONT  TestAccIdentityStoreGroupDataSource_groupIdConflictsWithExternalId
--- PASS: TestAccIdentityStoreGroupDataSource_groupIdConflictsWithExternalId (9.58s)
=== CONT  TestAccIdentityStoreGroupDataSource_groupIdFilterMismatch
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayName (18.45s)
=== CONT  TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupId (17.52s)
=== CONT  TestAccIdentityStoreGroupDataSource_groupIdConflictsWithUniqueAttribute
--- PASS: TestAccIdentityStoreGroupDataSource_groupIdFilterMismatch (9.25s)
=== CONT  TestAccIdentityStoreGroupDataSource_filterConflictsWithUniqueAttribute
--- PASS: TestAccIdentityStoreGroupDataSource_groupIdConflictsWithUniqueAttribute (8.75s)
--- PASS: TestAccIdentityStoreGroupDataSource_filterConflictsWithUniqueAttribute (8.27s)
--- PASS: TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName (17.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	41.821s
% make testacc TESTARGS='-run=TestAccIdentityStoreGroup_' PKG=identitystore ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 3  -run=TestAccIdentityStoreGroup_ -timeout 180m
=== RUN   TestAccIdentityStoreGroup_basic
=== PAUSE TestAccIdentityStoreGroup_basic
=== RUN   TestAccIdentityStoreGroup_disappears
=== PAUSE TestAccIdentityStoreGroup_disappears
=== CONT  TestAccIdentityStoreGroup_basic
=== CONT  TestAccIdentityStoreGroup_disappears
--- PASS: TestAccIdentityStoreGroup_disappears (16.81s)
--- PASS: TestAccIdentityStoreGroup_basic (20.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	25.590s

@ewbankkit
IdentityStore: Skip acceptance tests if insufficient IAM privs.
21d3ace
@ewbankkit
r/aws_identitystore_group: Cosmetics.
800e6a0 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccIdentityStoreGroup_' PKG=identitystore ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 3  -run=TestAccIdentityStoreGroup_ -timeout 180m
=== RUN   TestAccIdentityStoreGroup_basic
=== PAUSE TestAccIdentityStoreGroup_basic
=== RUN   TestAccIdentityStoreGroup_disappears
=== PAUSE TestAccIdentityStoreGroup_disappears
=== CONT  TestAccIdentityStoreGroup_basic
=== CONT  TestAccIdentityStoreGroup_disappears
--- PASS: TestAccIdentityStoreGroup_disappears (16.81s)
--- PASS: TestAccIdentityStoreGroup_basic (20.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	25.590s
@ewbankkit
d/aws_identitystore_group: Use 'ListGroups' API if 'filter' is specif…
9cf5cbf 
…ied.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccIdentityStoreGroupDataSource_' PKG=identitystore ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 3  -run=TestAccIdentityStoreGroupDataSource_ -timeout 180m
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupId
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupId
=== RUN   TestAccIdentityStoreGroupDataSource_nonExistent
=== PAUSE TestAccIdentityStoreGroupDataSource_nonExistent
=== RUN   TestAccIdentityStoreGroupDataSource_groupIdFilterMismatch
=== PAUSE TestAccIdentityStoreGroupDataSource_groupIdFilterMismatch
=== RUN   TestAccIdentityStoreGroupDataSource_externalIdConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreGroupDataSource_externalIdConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreGroupDataSource_filterConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreGroupDataSource_filterConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreGroupDataSource_groupIdConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreGroupDataSource_groupIdConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreGroupDataSource_filterConflictsWithExternalId
=== PAUSE TestAccIdentityStoreGroupDataSource_filterConflictsWithExternalId
=== RUN   TestAccIdentityStoreGroupDataSource_groupIdConflictsWithExternalId
=== PAUSE TestAccIdentityStoreGroupDataSource_groupIdConflictsWithExternalId
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayName
=== CONT  TestAccIdentityStoreGroupDataSource_externalIdConflictsWithUniqueAttribute
=== CONT  TestAccIdentityStoreGroupDataSource_nonExistent
--- PASS: TestAccIdentityStoreGroupDataSource_externalIdConflictsWithUniqueAttribute (2.85s)
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupId
--- PASS: TestAccIdentityStoreGroupDataSource_nonExistent (4.36s)
=== CONT  TestAccIdentityStoreGroupDataSource_filterConflictsWithExternalId
--- PASS: TestAccIdentityStoreGroupDataSource_filterConflictsWithExternalId (1.72s)
=== CONT  TestAccIdentityStoreGroupDataSource_groupIdConflictsWithExternalId
--- PASS: TestAccIdentityStoreGroupDataSource_groupIdConflictsWithExternalId (9.58s)
=== CONT  TestAccIdentityStoreGroupDataSource_groupIdFilterMismatch
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayName (18.45s)
=== CONT  TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupId (17.52s)
=== CONT  TestAccIdentityStoreGroupDataSource_groupIdConflictsWithUniqueAttribute
--- PASS: TestAccIdentityStoreGroupDataSource_groupIdFilterMismatch (9.25s)
=== CONT  TestAccIdentityStoreGroupDataSource_filterConflictsWithUniqueAttribute
--- PASS: TestAccIdentityStoreGroupDataSource_groupIdConflictsWithUniqueAttribute (8.75s)
--- PASS: TestAccIdentityStoreGroupDataSource_filterConflictsWithUniqueAttribute (8.27s)
--- PASS: TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName (17.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	41.821s
@ewbankkit
r/aws_identitystore_user: Cosmetics.
dff5ec2 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccIdentityStoreUser_' PKG=identitystore ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 3  -run=TestAccIdentityStoreUser_ -timeout 180m
=== RUN   TestAccIdentityStoreUser_basic
=== PAUSE TestAccIdentityStoreUser_basic
=== RUN   TestAccIdentityStoreUser_disappears
=== PAUSE TestAccIdentityStoreUser_disappears
=== RUN   TestAccIdentityStoreUser_Addresses
=== PAUSE TestAccIdentityStoreUser_Addresses
=== RUN   TestAccIdentityStoreUser_Emails
=== PAUSE TestAccIdentityStoreUser_Emails
=== RUN   TestAccIdentityStoreUser_Locale
=== PAUSE TestAccIdentityStoreUser_Locale
=== RUN   TestAccIdentityStoreUser_NameFamilyName
=== PAUSE TestAccIdentityStoreUser_NameFamilyName
=== RUN   TestAccIdentityStoreUser_NameFormatted
=== PAUSE TestAccIdentityStoreUser_NameFormatted
=== RUN   TestAccIdentityStoreUser_NameGivenName
=== PAUSE TestAccIdentityStoreUser_NameGivenName
=== RUN   TestAccIdentityStoreUser_NameHonorificPrefix
=== PAUSE TestAccIdentityStoreUser_NameHonorificPrefix
=== RUN   TestAccIdentityStoreUser_NameHonorificSuffix
=== PAUSE TestAccIdentityStoreUser_NameHonorificSuffix
=== RUN   TestAccIdentityStoreUser_NameMiddleName
=== PAUSE TestAccIdentityStoreUser_NameMiddleName
=== RUN   TestAccIdentityStoreUser_NickName
=== PAUSE TestAccIdentityStoreUser_NickName
=== RUN   TestAccIdentityStoreUser_PhoneNumbers
=== PAUSE TestAccIdentityStoreUser_PhoneNumbers
=== RUN   TestAccIdentityStoreUser_PreferredLanguage
=== PAUSE TestAccIdentityStoreUser_PreferredLanguage
=== RUN   TestAccIdentityStoreUser_ProfileURL
=== PAUSE TestAccIdentityStoreUser_ProfileURL
=== RUN   TestAccIdentityStoreUser_Timezone
=== PAUSE TestAccIdentityStoreUser_Timezone
=== RUN   TestAccIdentityStoreUser_Title
=== PAUSE TestAccIdentityStoreUser_Title
=== RUN   TestAccIdentityStoreUser_UserType
=== PAUSE TestAccIdentityStoreUser_UserType
=== CONT  TestAccIdentityStoreUser_basic
=== CONT  TestAccIdentityStoreUser_NickName
=== CONT  TestAccIdentityStoreUser_Timezone
--- PASS: TestAccIdentityStoreUser_basic (20.96s)
=== CONT  TestAccIdentityStoreUser_UserType
--- PASS: TestAccIdentityStoreUser_NickName (50.48s)
=== CONT  TestAccIdentityStoreUser_Title
--- PASS: TestAccIdentityStoreUser_Timezone (51.28s)
=== CONT  TestAccIdentityStoreUser_PreferredLanguage
--- PASS: TestAccIdentityStoreUser_UserType (48.66s)
=== CONT  TestAccIdentityStoreUser_ProfileURL
--- PASS: TestAccIdentityStoreUser_Title (49.03s)
=== CONT  TestAccIdentityStoreUser_PhoneNumbers
--- PASS: TestAccIdentityStoreUser_PreferredLanguage (49.54s)
=== CONT  TestAccIdentityStoreUser_NameHonorificSuffix
--- PASS: TestAccIdentityStoreUser_ProfileURL (50.08s)
=== CONT  TestAccIdentityStoreUser_NameMiddleName
--- PASS: TestAccIdentityStoreUser_NameHonorificSuffix (47.67s)
=== CONT  TestAccIdentityStoreUser_Emails
--- PASS: TestAccIdentityStoreUser_PhoneNumbers (67.63s)
=== CONT  TestAccIdentityStoreUser_NameFamilyName
--- PASS: TestAccIdentityStoreUser_NameMiddleName (49.21s)
=== CONT  TestAccIdentityStoreUser_Locale
--- PASS: TestAccIdentityStoreUser_NameFamilyName (35.81s)
=== CONT  TestAccIdentityStoreUser_Addresses
--- PASS: TestAccIdentityStoreUser_Emails (72.48s)
=== CONT  TestAccIdentityStoreUser_NameFormatted
--- PASS: TestAccIdentityStoreUser_Locale (52.44s)
=== CONT  TestAccIdentityStoreUser_NameHonorificPrefix
--- PASS: TestAccIdentityStoreUser_NameHonorificPrefix (35.72s)
=== CONT  TestAccIdentityStoreUser_NameGivenName
--- PASS: TestAccIdentityStoreUser_NameFormatted (55.32s)
=== CONT  TestAccIdentityStoreUser_disappears
--- PASS: TestAccIdentityStoreUser_Addresses (76.54s)
--- PASS: TestAccIdentityStoreUser_disappears (15.51s)
--- PASS: TestAccIdentityStoreUser_NameGivenName (35.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	297.802s
@ewbankkit
d/aws_identitystore_user: Use 'ListUsers' API if 'filter' is specified.
863199a 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccIdentityStoreUserDataSource_' PKG=identitystore ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 3  -run=TestAccIdentityStoreUserDataSource_ -timeout 180m
=== RUN   TestAccIdentityStoreUserDataSource_basic
=== PAUSE TestAccIdentityStoreUserDataSource_basic
=== RUN   TestAccIdentityStoreUserDataSource_filterUserName
=== PAUSE TestAccIdentityStoreUserDataSource_filterUserName
=== RUN   TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== PAUSE TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== RUN   TestAccIdentityStoreUserDataSource_email
=== PAUSE TestAccIdentityStoreUserDataSource_email
=== RUN   TestAccIdentityStoreUserDataSource_userID
=== PAUSE TestAccIdentityStoreUserDataSource_userID
=== RUN   TestAccIdentityStoreUserDataSource_nonExistent
=== PAUSE TestAccIdentityStoreUserDataSource_nonExistent
=== RUN   TestAccIdentityStoreUserDataSource_userIdFilterMismatch
=== PAUSE TestAccIdentityStoreUserDataSource_userIdFilterMismatch
=== RUN   TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== PAUSE TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== RUN   TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
=== PAUSE TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
=== RUN   TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
=== PAUSE TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
=== CONT  TestAccIdentityStoreUserDataSource_basic
=== CONT  TestAccIdentityStoreUserDataSource_nonExistent
=== CONT  TestAccIdentityStoreUserDataSource_email
--- PASS: TestAccIdentityStoreUserDataSource_nonExistent (4.63s)
=== CONT  TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId
--- PASS: TestAccIdentityStoreUserDataSource_filterConflictsWithExternalId (9.63s)
=== CONT  TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId
--- PASS: TestAccIdentityStoreUserDataSource_basic (19.32s)
=== CONT  TestAccIdentityStoreUserDataSource_userID
--- PASS: TestAccIdentityStoreUserDataSource_email (20.24s)
=== CONT  TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute
=== CONT  TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
--- PASS: TestAccIdentityStoreUserDataSource_externalIdConflictsWithUniqueAttribute (1.56s)
--- PASS: TestAccIdentityStoreUserDataSource_userIdConflictsWithExternalId (9.46s)
=== CONT  TestAccIdentityStoreUserDataSource_filterUserName
--- PASS: TestAccIdentityStoreUserDataSource_userID (17.71s)
=== CONT  TestAccIdentityStoreUserDataSource_userIdFilterMismatch
--- PASS: TestAccIdentityStoreUserDataSource_uniqueAttributeUserName (18.37s)
--- PASS: TestAccIdentityStoreUserDataSource_filterUserName (17.62s)
--- PASS: TestAccIdentityStoreUserDataSource_userIdFilterMismatch (9.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	52.104s
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/identitystore Issues and PRs that pertain to the identitystore service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 17, 2023
This was referenced Jan 17, 2023
Closed
Closed
@ewbankkit ewbankkit merged commit 41ca6f1 into main Jan 17, 2023
@ewbankkit ewbankkit deleted the b-aws_identitystore_user-400 branch January 17, 2023 20:40
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 17, 2023
github-actions bot pushed a commit that referenced this pull request Jan 17, 2023
Update CHANGELOG.md for #28937
fa45b42
@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/identitystore Issues and PRs that pertain to the identitystore service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.51.0
1 participant
@ewbankkit