Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: #28839

Closed
sharepointoscar opened this issue Jan 11, 2023 · 5 comments · Fixed by #28924
Closed

[Bug]: #28839

sharepointoscar opened this issue Jan 11, 2023 · 5 comments · Fixed by #28924
Labels
bug Addresses a defect in current functionality. service/eks Issues and PRs that pertain to the eks service.
Milestone

Comments

@sharepointoscar
Copy link

Terraform Core Version

v1.3.7

AWS Provider Version

= 4.47

Affected Resource(s)

Expected Behavior

The expected behavior, is that the data source handles the outpost_config properly without errors.

Actual Behavior

The module throws an error.

Relevant Error/Panic Output Snippet

│ Error: setting outpost_config: Invalid address to set: []string{"outpost_config", "0", "control_plane_placement"}
│ 
│   with module.kubernetes-addons.data.aws_eks_cluster.eks_cluster,
│   on .terraform/modules/kubernetes-addons/modules/kubernetes-addons/data.tf line 14, in data "aws_eks_cluster" "eks_cluster":
│   14: data "aws_eks_cluster" "eks_cluster" {
│

Terraform Configuration Files

  1. Follow complete Outposts example

  2. Safe this file as addons.tf in the root where all other tf files are.

module "kubernetes-addons" {
  source = "github.com/aws-ia/terraform-aws-eks-blueprints?ref=v4.20.0/modules/kubernetes-addons"

  eks_cluster_id       = module.eks.cluster_name
  eks_cluster_endpoint = module.eks.cluster_endpoint
  eks_oidc_provider    = module.eks.oidc_provider
  eks_cluster_version  = module.eks.cluster_version

  #---------------------------------------------------------------
  # ARGO CD ADD-ON
  #---------------------------------------------------------------

  enable_argocd         = false
  argocd_manage_add_ons = true # Indicates that ArgoCD is responsible for managing/deploying Add-ons.
  argocd_applications = {
    addons    = local.addon_application
    #workloads = local.workload_application
  }

  argocd_helm_config = {
    values = [templatefile("${path.module}/manifests/argocd-values.yaml", {})]
  }

  #---------------------------------------------------------------
  # ADD-ONS - You can add additional addons here
  # https://aws-ia.github.io/terraform-aws-eks-blueprints/add-ons/
  #---------------------------------------------------------------
  enable_aws_load_balancer_controller  = false
  enable_amazon_eks_aws_ebs_csi_driver = false
  enable_aws_for_fluentbit            = true
  enable_cert_manager                 = false
  enable_cluster_autoscaler           = false
  enable_ingress_nginx                = false
  enable_keda                         = false
  enable_metrics_server               = false
  enable_prometheus                   = false
  enable_traefik                      = false
  enable_vpa                          = false
  enable_yunikorn                     = false
  enable_argo_rollouts                = false
  enable_promtail                     = false
  enable_karpenter                    = false
  enable_calico                       = false
  enable_grafana                      = false
} 

Steps to Reproduce

  1. In the root of the solution directory execute terraform apply -auto-approve
  2. You will see the error listed above.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@sharepointoscar sharepointoscar added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jan 11, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/eks Issues and PRs that pertain to the eks service. label Jan 11, 2023
@bryantbiggs
Copy link
Contributor

a smaller reproduction would be:

Using a local EKS cluster on Outposts (both control plane and data plane reside on Outposts), pass the name of the cluster into the cluster data source and you should see the associated error

data "aws_eks_cluster" "example" {
  name = "name-of-local-cluster-on-outposts"
}

@ewbankkit
Copy link
Contributor

Relates #28112.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 17, 2023
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 17, 2023
@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants