Feature/datasync task includes filter

[matiu3]

This is just a rebase of #21031 - which has been accepted, but not merged, and is in conflict now. I'm just submitting this, in the interest of getting the feature released quickly.

Closes #20849

[github-actions]

Welcome @matiu3 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSyncTask_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncTask_ -timeout 180m
=== RUN   TestAccDataSyncTask_basic
=== PAUSE TestAccDataSyncTask_basic
=== RUN   TestAccDataSyncTask_disappears
=== PAUSE TestAccDataSyncTask_disappears
=== RUN   TestAccDataSyncTask_schedule
=== PAUSE TestAccDataSyncTask_schedule
=== RUN   TestAccDataSyncTask_cloudWatchLogGroupARN
=== PAUSE TestAccDataSyncTask_cloudWatchLogGroupARN
=== RUN   TestAccDataSyncTask_excludes
=== PAUSE TestAccDataSyncTask_excludes
=== RUN   TestAccDataSyncTask_includes
=== PAUSE TestAccDataSyncTask_includes
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_gid
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_gid
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_logLevel
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_logLevel
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_transferMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_transferMode
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_uid
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_uid
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_verifyMode
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_verifyMode
=== RUN   TestAccDataSyncTask_tags
    acctest.go:69: Tagging on creation is inconsistent
--- SKIP: TestAccDataSyncTask_tags (0.00s)
=== CONT  TestAccDataSyncTask_basic
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_logLevel
--- PASS: TestAccDataSyncTask_basic (180.59s)
=== CONT  TestAccDataSyncTask_includes
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_logLevel (228.81s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_gid
--- PASS: TestAccDataSyncTask_includes (186.13s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_gid (238.63s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond (225.41s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_taskQueueing
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_atimeMtime (235.62s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_verifyMode
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_taskQueueing (184.43s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_uid
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_verifyMode (238.22s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_transferMode
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_uid (246.06s)
=== CONT  TestAccDataSyncTask_excludes
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_transferMode (190.69s)
=== CONT  TestAccDataSyncTask_schedule
--- PASS: TestAccDataSyncTask_excludes (193.55s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles
--- PASS: TestAccDataSyncTask_schedule (231.15s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles (186.45s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDevices (198.22s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_posixPermissions (217.58s)
=== CONT  TestAccDataSyncTask_disappears
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_overwriteMode (229.74s)
=== CONT  TestAccDataSyncTask_cloudWatchLogGroupARN
--- PASS: TestAccDataSyncTask_disappears (184.53s)
--- PASS: TestAccDataSyncTask_cloudWatchLogGroupARN (211.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	2006.655s

[ewbankkit]

@matiu3 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.