Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support schedulers argument in aws_mwaa_environment #21941

Merged

Conversation

wedge-jarrad
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20185

Output from acceptance testing:

$ gmake testacc TESTARGS='-run=TestAccMWAAEnvironment' PKG_NAME=internal/service/mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run=TestAccMWAAEnvironment -timeout 180m
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== RUN   TestAccMWAAEnvironment_disappears
=== PAUSE TestAccMWAAEnvironment_disappears
=== RUN   TestAccMWAAEnvironment_airflowOptions
=== PAUSE TestAccMWAAEnvironment_airflowOptions
=== RUN   TestAccMWAAEnvironment_log
=== PAUSE TestAccMWAAEnvironment_log
=== RUN   TestAccMWAAEnvironment_full
=== PAUSE TestAccMWAAEnvironment_full
=== RUN   TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== PAUSE TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== CONT  TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_full
=== CONT  TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== CONT  TestAccMWAAEnvironment_airflowOptions
=== CONT  TestAccMWAAEnvironment_log
=== CONT  TestAccMWAAEnvironment_disappears
--- PASS: TestAccMWAAEnvironment_full (1908.96s)
--- PASS: TestAccMWAAEnvironment_basic (2056.83s)
--- PASS: TestAccMWAAEnvironment_disappears (2059.16s)
--- PASS: TestAccMWAAEnvironment_log (2711.06s)
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (2767.79s)
--- PASS: TestAccMWAAEnvironment_airflowOptions (3374.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mwaa       3374.213s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/mwaa Issues and PRs that pertain to the mwaa service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 29, 2021
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2021
@tracycarley
Copy link

tracycarley commented Feb 2, 2022

Any plan or blocks for this one to be merged and be released?

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMWAAEnvironment_basic\|TestAccMWAAEnvironment_full' PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20  -run=TestAccMWAAEnvironment_basic\|TestAccMWAAEnvironment_full -timeout 180m
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== RUN   TestAccMWAAEnvironment_full
=== PAUSE TestAccMWAAEnvironment_full
=== CONT  TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_full
--- PASS: TestAccMWAAEnvironment_basic (2007.06s)
--- PASS: TestAccMWAAEnvironment_full (2041.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	2045.798s

@ewbankkit
Copy link
Contributor

@wedge-jarrad Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d1539f1 into hashicorp:main Mar 25, 2022
@github-actions github-actions bot added this to the v4.8.0 milestone Mar 25, 2022
@github-actions
Copy link

This functionality has been released in v4.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/mwaa Issues and PRs that pertain to the mwaa service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support schedulers value for aws_mwaa_environment resource
4 participants