Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/msk_cluster: Modernize resource #19537

Closed
YakDriver opened this issue May 26, 2021 · 2 comments · Fixed by #14627
Closed

r/msk_cluster: Modernize resource #19537

YakDriver opened this issue May 26, 2021 · 2 comments · Fixed by #14627
Labels
service/kafka Issues and PRs that pertain to the kafka service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@YakDriver
Copy link
Member

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

This resource needs to be modernized with the following changes:

  1. Expanders that are consistent with current best practices
  2. Flatteners that are consistent with current best practices
  3. A "disappears" test
  4. Use of d.IsNewResource() (related to "disappears" test)
  5. Refactoring waiters, statusers into aws/internal

New or Affected Resource(s)

  • aws_msk_cluster
@YakDriver YakDriver added the enhancement Requests to existing resources that expand the functionality or scope. label May 26, 2021
@ghost ghost added the service/kafka Issues and PRs that pertain to the kafka service. label May 26, 2021
@YakDriver YakDriver added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed enhancement Requests to existing resources that expand the functionality or scope. labels May 26, 2021
@github-actions github-actions bot added this to the v3.60.0 milestone Sep 21, 2021
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/kafka Issues and PRs that pertain to the kafka service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant