Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_imagebuilder_image_recipe should allow WorkingDirectory as parameter #16946

Closed
schabert opened this issue Jan 4, 2021 · 3 comments · Fixed by #16947
Closed

aws_imagebuilder_image_recipe should allow WorkingDirectory as parameter #16946

schabert opened this issue Jan 4, 2021 · 3 comments · Fixed by #16947
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Milestone

Comments

@schabert
Copy link
Contributor

schabert commented Jan 4, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The Resource Recipe allows a parameter "workingDirectory" but its missing in the module.

The CLI/API supports this with the variable working-directory

New or Affected Resource(s)

  • aws_imagebuilder_image_recipe

Potential Terraform Configuration

resource "aws_imagebuilder_image_recipe" "main" {
  description       = "Image Builder Recipe"
  name              = "test1"
  parent_image      = "arn:aws:imagebuilder:us-west-2:aws:image/windows-server-2019-english-core-base-x86/x.x.x"
  working_directory = "/workspace"
  version           = "1.0.0"

  # root disk
  block_device_mapping {
    device_name = "/dev/sda1"

    ebs {
      delete_on_termination = true
      encrypted             = true
      kms_key_id            = "alias/aws/ebs"
      volume_size           = 40
      volume_type           = "gp2"
    }
  }
  component {
    component_arn = "arn:aws:imagebuilder:us-west-2:aws:component/update-windows/x.x.x"
  }
}

References

@schabert schabert added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 4, 2021
@ghost ghost added the service/imagebuilder Issues and PRs that pertain to the imagebuilder service. label Jan 4, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 4, 2021
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 4, 2021
@bflad bflad self-assigned this Jan 4, 2021
@bflad bflad added this to the v3.23.0 milestone Jan 4, 2021
@bflad
Copy link
Contributor

bflad commented Jan 4, 2021

Support for this functionality has been merged and will release with version 3.23.0 of the Terraform AWS Provider, later this week. Thanks to @schabert for the implementation.

@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants