Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_timestreamwrite_table #15422

Closed
yardensachs opened this issue Oct 1, 2020 · 12 comments · Fixed by #19354
Closed

New Resource: aws_timestreamwrite_table #15422

yardensachs opened this issue Oct 1, 2020 · 12 comments · Fixed by #19354
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service.
Milestone

Comments

@yardensachs
Copy link
Contributor

yardensachs commented Oct 1, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon Timestream is now generally available, and a supporting Terraform resource for managing a table is necessary. Amazon Timestream is a fast, scalable, fully managed, purpose-built time series database.
(#15421 was created for aws_timestreamwrite_database)

New or Affected Resource(s)

  • aws_timestreamwrite_table

Potential Terraform Configuration

resource "aws_timestreamwrite_table" "example" {
  database_name = aws_timestreamwrite_database.database_name
  table_name    = "string"
  retention_properties {
    magnetic_store_retention_period_in_days = 10
    memory_store_retention_period_in_hours  = 10
  }
  tags = {
    Name = "value"
  }
}
  • database_name (string) -- The name of the Timestream database.
  • table_name (string) -- The name of the Timestream table.
  • retention_properties.magnetic_store_retention_period_in_days (int) -- The duration for which data must be stored in the magnetic store.
  • retention_properties.memory_store_retention_period_in_hours (int) -- The duration for which data must be stored in the memory store.

References

@yardensachs yardensachs added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 1, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 1, 2020
@roberth-k
Copy link
Contributor

API documentation is part of the Developer Guide: https://docs.aws.amazon.com/timestream/latest/developerguide/API_Reference.html.

@ewbankkit
Copy link
Contributor

Strictly, this resource should be named aws_timestreamwrite_table to match the AWS service name and the resource naming conventions.
AWS call the underlying API the Timestream Write API.

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Oct 1, 2020
@yardensachs yardensachs changed the title New Resource: aws_timestream_table New Resource: aws_timestreamwrite_table Oct 1, 2020
@yardensachs
Copy link
Contributor Author

@ewbankkit Updated

@ewbankkit
Copy link
Contributor

@TomTucka
Copy link
Contributor

TomTucka commented Oct 7, 2020

I started working on this, should have a PR open by tomorrow evening 🙂

@yardensachs
Copy link
Contributor Author

Hi @TomTucka thanks!
I have a draft branch for tables waiting and ready actually, but I cant finish it before the team reviews #15463
Because you would need a database first anyway for testing

@dusansusic
Copy link
Contributor

Is there any timeframe when this could to be merged?

@ivanovit
Copy link

Hi @yardensachs, Could you please share the draft branch for tables?

@yardensachs
Copy link
Contributor Author

@ivanovit looks like I lost that branch for some reason, so I don't have that work anymore :(

@anGie44 anGie44 added service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 7, 2021
@anGie44
Copy link
Contributor

anGie44 commented May 8, 2021

Hi @yardensachs 👋 Apologies for the wait here! Totally understand if its not the best time to pick up doing the implementation for this again, but if you are still interested, let us know 😄 We'll wait about a week to hear back, and then from there, I'm happy to continue the implementation.

@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label May 8, 2021
@anGie44 anGie44 removed the waiting-response Maintainers are waiting on response from community or contributor. label May 13, 2021
@github-actions github-actions bot added this to the v3.40.0 milestone May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants