r/aws_finspace_kx_dataview: compose syntheric arn on read

Properly setting the arn attribute will allow transparent tagging to properly list tags on the underlying data view during read operations. This should fix persistent diffs when setting tags for this resource.

Author: jar-b

.changelog/34998.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_finspace_kx_dataview: Properly set `arn` attribute on read, resolving persistent differences when `tags` are configured
+```

internal/service/finspace/kx_dataview.go

@@ -6,10 +6,12 @@ package finspace
 import (
 	"context"
 	"errors"
+	"fmt"
 	"log"
 	"time"
 
 	"github.com/aws/aws-sdk-go-v2/aws"
+	"github.com/aws/aws-sdk-go-v2/aws/arn"
 	"github.com/aws/aws-sdk-go-v2/service/finspace"
 	"github.com/aws/aws-sdk-go-v2/service/finspace/types"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
@@ -140,22 +142,25 @@ func resourceKxDataviewCreate(ctx context.Context, d *schema.ResourceData, meta
 	var diags diag.Diagnostics
 	conn := meta.(*conns.AWSClient).FinSpaceClient(ctx)
 
+	environmentID := d.Get("environment_id").(string)
+	databaseName := d.Get("database_name").(string)
+	name := d.Get("name").(string)
+
 	idParts := []string{
-		d.Get("environment_id").(string),
-		d.Get("database_name").(string),
-		d.Get("name").(string),
+		environmentID,
+		databaseName,
+		name,
 	}
-
 	rId, err := flex.FlattenResourceId(idParts, kxDataviewIdPartCount, false)
 	if err != nil {
 		return create.AppendDiagError(diags, names.FinSpace, create.ErrActionFlatteningResourceId, ResNameKxDataview, d.Get("name").(string), err)
 	}
 	d.SetId(rId)
 
 	in := &finspace.CreateKxDataviewInput{
-		DatabaseName:  aws.String(d.Get("database_name").(string)),
-		DataviewName:  aws.String(d.Get("name").(string)),
-		EnvironmentId: aws.String(d.Get("environment_id").(string)),
+		DatabaseName:  aws.String(databaseName),
+		DataviewName:  aws.String(name),
+		EnvironmentId: aws.String(environmentID),
 		AutoUpdate:    d.Get("auto_update").(bool),
 		AzMode:        types.KxAzMode(d.Get("az_mode").(string)),
 		ClientToken:   aws.String(id.UniqueId()),
@@ -190,17 +195,6 @@ func resourceKxDataviewCreate(ctx context.Context, d *schema.ResourceData, meta
 		return create.AppendDiagError(diags, names.FinSpace, create.ErrActionWaitingForCreation, ResNameKxDataview, d.Get("name").(string), err)
 	}
 
-	// The CreateKxDataview API currently fails to tag the Dataview when the
-	// Tags field is set. Until the API is fixed, tag after creation instead.
-	//
-	// TODO: the identifier passed to createTags here likely needs to be an ARN, but this attribute
-	// is not returned from the create or describe APIs. The ARN may need to be manually constructed
-	// in order for tag after create to function.
-	//
-	// if err := createTags(ctx, conn, aws.ToString(out.DataviewName), getTagsIn(ctx)); err != nil {
-	//     return create.AppendDiagError(diags, names.FinSpace, create.ErrActionCreating, ResNameKxDataview, d.Id(), err)
-	// }
-
 	return append(diags, resourceKxDataviewRead(ctx, d, meta)...)
 }
 
@@ -233,6 +227,19 @@ func resourceKxDataviewRead(ctx context.Context, d *schema.ResourceData, meta in
 		return create.AppendDiagError(diags, names.FinSpace, create.ErrActionReading, ResNameKxDataview, d.Id(), err)
 	}
 
+	// Manually construct the dataview ARN, which is not returned from the
+	// Create or Describe APIs.
+	//
+	// Ref: https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazonfinspace.html#amazonfinspace-resources-for-iam-policies
+	dataviewARN := arn.ARN{
+		Partition: meta.(*conns.AWSClient).Partition,
+		Region:    meta.(*conns.AWSClient).Region,
+		Service:   names.FinSpace,
+		AccountID: meta.(*conns.AWSClient).AccountID,
+		Resource:  fmt.Sprintf("kxEnvironment/%s/kxDatabase/%s/kxDataview/%s", aws.ToString(out.EnvironmentId), aws.ToString(out.DatabaseName), aws.ToString(out.DataviewName)),
+	}.String()
+	d.Set("arn", dataviewARN)
+
 	return diags
 }