Merge pull request #28791 from hashicorp/b-backup-vault-policy

YakDriver · web-flow · commit 7a7997fa0ec4 · 2023-01-10T11:05:46.000-05:00
backup/vault_policy: Improve diff handling for policies
diff --git a/.changelog/28791.txt b/.changelog/28791.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_backup_vault_policy: Improve refresh to avoid unnecessary diffs in `policy`
+```
diff --git a/internal/service/backup/vault_policy.go b/internal/service/backup/vault_policy.go
@@ -36,10 +36,11 @@ func ResourceVaultPolicy() *schema.Resource {
 				ForceNew: true,
 			},
 			"policy": {
-				Type:             schema.TypeString,
-				Required:         true,
-				ValidateFunc:     validation.StringIsJSON,
-				DiffSuppressFunc: verify.SuppressEquivalentPolicyDiffs,
+				Type:                  schema.TypeString,
+				Required:              true,
+				ValidateFunc:          validation.StringIsJSON,
+				DiffSuppressFunc:      verify.SuppressEquivalentPolicyDiffs,
+				DiffSuppressOnRefresh: true,
 				StateFunc: func(v interface{}) string {
 					json, _ := structure.NormalizeJsonString(v)
 					return json

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:bug
	`2`	+resource/aws_backup_vault_policy: Improve refresh to avoid unnecessary diffs in `policy`
	`3`	+```