Skip to content

Commit 6d4ea49

Browse files
authored
r/aws_ses_configuration_set: fix crash when reputation_metrics_enabled is set (#38921)
Migration of this service to AWS SDK for Go V2 unintentionally introduced an assertion to a pointer to bool, rather than a bool. ```console % make testacc PKG=ses TESTS=TestAccSESConfigurationSet_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/ses/... -v -count 1 -parallel 20 -run='TestAccSESConfigurationSet_' -timeout 360m --- PASS: TestAccSESConfigurationSet_disappears (13.24s) --- PASS: TestAccSESConfigurationSet_deliveryOptions (15.27s) --- PASS: TestAccSESConfigurationSet_basic (15.29s) --- PASS: TestAccSESConfigurationSet_emptyDeliveryOptions (20.05s) --- PASS: TestAccSESConfigurationSet_sendingEnabled (29.13s) --- PASS: TestAccSESConfigurationSet_Update_emptyDeliveryOptions (35.44s) --- PASS: TestAccSESConfigurationSet_reputationMetricsEnabled (37.59s) --- PASS: TestAccSESConfigurationSet_Update_deliveryOptions (37.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ses 43.956s ```
1 parent bfa0c1b commit 6d4ea49

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.changelog/38921.txt

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
resource/aws_ses_configuration_set: Fix crash when `reputation_metrics_enabled` is set to `true`
3+
```

internal/service/ses/configuration_set.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func resourceConfigurationSetCreate(ctx context.Context, d *schema.ResourceData,
127127
if v := d.Get("reputation_metrics_enabled"); v.(bool) {
128128
input := &ses.UpdateConfigurationSetReputationMetricsEnabledInput{
129129
ConfigurationSetName: aws.String(configurationSetName),
130-
Enabled: aws.ToBool(v.(*bool)),
130+
Enabled: v.(bool),
131131
}
132132

133133
_, err := conn.UpdateConfigurationSetReputationMetricsEnabled(ctx, input)

0 commit comments

Comments
 (0)