fixed tag + environment update

Author: alexknez

.changelog/36074.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_elastic_beanstalk_environment: Ensure sequential update of tags and environment properties to prevent InvalidParameterValue error
+```

internal/service/elasticbeanstalk/environment.go

@@ -451,11 +451,18 @@ func resourceEnvironmentUpdate(ctx context.Context, d *schema.ResourceData, meta
 
 	opTime := time.Now()
 
-	if d.HasChangesExcept("tags", "tags_all", "wait_for_ready_timeout", "poll_interval") {
+	if d.HasChangesExcept("wait_for_ready_timeout", "poll_interval") {
 		input := elasticbeanstalk.UpdateEnvironmentInput{
 			EnvironmentId: aws.String(d.Id()),
 		}
 
+		if d.HasChange("tags_all") {
+			log.Printf("[DEBUG] Waiting for Elastic Beanstalk environment %s to become ready after updating tags", d.Id())
+			if _, err := waitEnvironmentReady(ctx, conn, d.Id(), pollInterval, waitForReadyTimeOut); err != nil {
+				return sdkdiag.AppendErrorf(diags, "waiting for Elastic Beanstalk Environment (%s) tag update: %s", d.Id(), err)
+			}
+		}
+
 		if d.HasChange("description") {
 			input.Description = aws.String(d.Get("description").(string))
 		}