Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Set validation for SizeAtLeast, SizeAtMost and SizeBetween #40

Merged
merged 11 commits into from
Jun 23, 2022
Merged

Adding Set validation for SizeAtLeast, SizeAtMost and SizeBetween #40

merged 11 commits into from
Jun 23, 2022

Conversation

bendbennett
Copy link
Contributor

Closes: #5

@bendbennett bendbennett requested a review from a team as a code owner June 21, 2022 15:36
@bendbennett bendbennett changed the base branch from main to bendbennett/issues-12 June 21, 2022 15:36
@bendbennett
Copy link
Contributor Author

Following discussion with @detro we could consolidate the SizeAtLeast, SizeAtMost and SizeBetween validators for List, Map and Set into a single generic validator if we don't require any type-specific validation.

@bflad bflad added enhancement New feature or request type/set types.Set validators labels Jun 22, 2022
bflad
bflad approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than missing Go documentation for provider developers and changelog entry, looks good to me 🚀

setvalidator/size_at_least.go
}
}

func SizeAtLeast(min int) tfsdk.AttributeValidator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go documentation 😉

setvalidator/size_at_most.go
}
}

func SizeAtMost(max int) tfsdk.AttributeValidator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go documentation 😉

setvalidator/size_between.go
}
}

func SizeBetween(min, max int) tfsdk.AttributeValidator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go documentation 😉

@bflad bflad added this to the v0.3.0 milestone Jun 22, 2022
@bendbennett bendbennett force-pushed the bendbennett/issues-5 branch from 77c0a76 to 2e2bc0c Compare June 22, 2022 14:33
@bendbennett bendbennett force-pushed the bendbennett/issues-12 branch from 2013d59 to d106fc2 Compare June 22, 2022 16:00
@bendbennett bendbennett force-pushed the bendbennett/issues-5 branch from 2e2bc0c to 375b34d Compare June 22, 2022 16:02
@bendbennett bendbennett force-pushed the bendbennett/issues-5 branch from 375b34d to e71aeef Compare June 23, 2022 07:57
Base automatically changed from bendbennett/issues-12 to main June 23, 2022 11:33
@bendbennett bendbennett merged commit 32de284 into main Jun 23, 2022
@bendbennett bendbennett deleted the bendbennett/issues-5 branch June 23, 2022 11:50
bflad added a commit that referenced this pull request Jun 29, 2022
@bflad
Update CHANGELOG for consistency with #39, #40, #41, #42, #45
b32b118
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request type/set types.Set validators
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Set Size Validation (SizeAtLeast / SizeAtMost / SizeBetween)
2 participants
@bendbennett @bflad