Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Add package level Go documentation and fix int64validator package naming in source files #25

Merged
merged 1 commit into from
May 25, 2022
Merged

all: Add package level Go documentation and fix int64validator package naming in source files #25

merged 1 commit into from
May 25, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 25, 2022

Reference: https://pkg.go.dev/github.com/hashicorp/terraform-plugin-framework-validators

This will improve the usability of browsing the Go documentation.

@bflad
all: Add package level Go documentation and fix int64validator packag…
d1d7e5f 
…e naming in source files

Reference: https://pkg.go.dev/github.com/hashicorp/terraform-plugin-framework-validators

This will improve the usability of browsing the Go documentation.
@bflad bflad added documentation Improvements or additions to documentation type/float64 types.Float64 validators type/int64 types.Int64 validators type/string types.String validators labels May 25, 2022
@bflad bflad requested a review from a team as a code owner May 25, 2022 14:12
ewbankkit
ewbankkit approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@bflad bflad added this to the v0.2.0 milestone May 25, 2022
@bflad bflad merged commit 57f28bb into main May 25, 2022
@bflad bflad deleted the bflad-package-godoc branch May 25, 2022 16:10
detro pushed a commit that referenced this pull request Jun 7, 2022
Adding changelog notes for #25
443c749
detro added a commit that referenced this pull request Jun 7, 2022
@detro
Release v0.2.0 (#33)
53629d9 
* Adding changelog notes for #25

* Git-ignoring JetBrains IDEs project files

* Preparing CHANGELOG for 0.2.0
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation type/float64 types.Float64 validators type/int64 types.Int64 validators type/string types.String validators
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @ewbankkit