Check for submodules when fetching schemas from the registry #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The registry client always used the Inputs and Outputs from the root module when fetching and storing a schema for a module with a registry address. We now check if the source address contains a sub directory and use the Inputs and Outputs from the matching submodule.
dbanck
force-pushed
the
b-store-submodule-schema
branch
from
5e303a8 to
70d2e78
Compare
jpogran
approved these changes
Jul 19, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1771
Closes hashicorp/vscode-terraform#1800
The registry client always used the Inputs and Outputs from the root module when fetching and storing a schema for a module with a registry address.
We now check if the source address contains a sub directory and use the Inputs and Outputs from the matching submodule.
UX Before
UX After