Skip to content

Commit 747603f

Browse files
committed
Remove pipenv dependency
pipenv is really slow and sometimes it hangs for a really long time. Perhaps because I'm using a private PyPi instance that makes it worse, but that works fine with plain pip. This seems to be a common problem - see and the several other linked issues there: pypa/pipenv#3827 So far, this is just the result of grep/search/replace. Haven't tested this at all and there's more work to do. Just want to start by getting some feedback if this is going to be something that everyone is OK with. Closes #324
1 parent 06cf128 commit 747603f

29 files changed

+37
-369
lines changed

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM jsii/superchain
22

3-
RUN yum install -y unzip && curl https://raw.githubusercontent.com/pypa/pipenv/master/get-pipenv.py | python
3+
RUN yum install -y unzip
44

55
ENV DEFAULT_TERRAFORM_VERSION=0.13.0
66

docs/getting-started/python.md

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
- [Terraform](https://www.terraform.io/downloads.html) >= v0.12
66
- [Node.js](https://nodejs.org) >= v12.16
77
- [Python](https://www.python.org/downloads/) >= v3.7
8-
- [Pipenv](https://pipenv.pypa.io/en/latest/install/#installing-pipenv/)
98

109
### Install CDK for Terraform CLI
1110

examples/python/aws/Pipfile

-10
This file was deleted.

examples/python/aws/Pipfile.lock

-90
This file was deleted.

examples/python/aws/README.md

+1-8
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,10 @@ A CDK for Terraform application in Python.
44

55
## Usage
66

7-
Install Pipenv using Homebrew by running:
8-
9-
```bash
10-
$ brew install pipenv
11-
```
12-
You can install Pipenv by visiting the [website](https://pipenv.pypa.io/en/latest/).
13-
147
Install project dependencies
158

169
```shell
17-
pipenv install
10+
pip3 install -r requirements.txt
1811
```
1912

2013
Generate CDK for Terraform constructs for Terraform provides and modules used in the project.

examples/python/aws/cdktf.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"language": "python",
3-
"app": "pipenv run ./main.py",
3+
"app": "python3 main.py",
44
"terraformProviders": ["aws@~> 2.0"],
55
"terraformModules": ["terraform-aws-modules/vpc/aws"],
66
"codeMakerOutput": "imports"
7-
}
7+
}

examples/python/aws/requirements.txt

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
./../../../dist/python/cdktf-0.0.0-py3-none-any.whl

examples/python/docker/Pipfile

-10
This file was deleted.

examples/python/docker/Pipfile.lock

-90
This file was deleted.

examples/python/docker/README.md

+1-8
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,10 @@
33

44
## Usage
55

6-
Install Pipenv using Homebrew by running:
7-
8-
```bash
9-
$ brew install pipenv
10-
```
11-
You can install Pipenv by visiting the [website](https://pipenv.pypa.io/en/latest/).
12-
136
Install project dependencies
147

158
```shell
16-
pipenv install
9+
pip3 install -r requirements.txt
1710
```
1811

1912
Generate CDK for Terraform constructs for Terraform provides and modules used in the project.

examples/python/docker/cdktf.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"language": "python",
3-
"app": "pipenv run ./main.py",
3+
"app": "python3 main.py",
44
"terraformProviders": [
55
"terraform-providers/docker@~> 2.0"
66
],
77
"codeMakerOutput": "imports"
8-
}
8+
}

examples/python/docker/help

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
cat help Prints this message
66

77
Compile:
8-
pipenv run ./main.py Compile and run the python code.
8+
python main.py Compile and run the python code.
99

1010
Synthesize:
1111
cdktf synth Synthesize Terraform resources to cdktf.out/
12-
12+
1313
Diff:
1414
cdktf diff Perform a diff (terraform plan) for the given stack
1515

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
./../../../dist/python/cdktf-0.0.0-py3-none-any.whl

examples/python/kubernetes/Pipfile

-10
This file was deleted.

0 commit comments

Comments
 (0)