-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: public key import and nicknames #1573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ed01ed
to
3da134f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
==========================================
+ Coverage 99.07% 99.10% +0.02%
==========================================
Files 159 161 +2
Lines 5959 6148 +189
Branches 1101 1138 +37
==========================================
+ Hits 5904 6093 +189
- Misses 52 55 +3
+ Partials 3 0 -3
|
2dbb6bf
to
f81f337
Compare
jbair06
requested changes
Feb 25, 2025
...end/src/renderer/pages/Settings/components/PublicKeysTab/components/RenamePublicKeyModal.vue
Outdated
Show resolved
Hide resolved
6d47320
to
554ddb0
Compare
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
Signed-off-by: Hristiyan <hristiyan.valkov@limechain.tech>
815e329
to
cf13f5a
Compare
jbair06
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new feature: importing public keys and assigning them a nickname.
Key Additions:
Backend Enhancements:
PS: This is a fairly large feature, so I might have missed something - feel free to ping me if you spot anything :)
Related issue(s):
#1428 #1537