do not call tcp/udp ::stopAll() when it is not required to do so (esp8266#8598)

d-a-v · hasenradball · commit 4ab5ad875435 · 2024-11-18T17:40:54.000+01:00
* do not call tcp/udp ::stopAll() when it is not required to to so
* remove stopAll also from ArduinoOTA
diff --git a/libraries/ArduinoOTA/ArduinoOTA.cpp b/libraries/ArduinoOTA/ArduinoOTA.cpp
@@ -265,8 +265,6 @@ void ArduinoOTAClass::_runUpdate() {
   delay(100);
 
   Update.setMD5(_md5.c_str());
-  WiFiUDP::stopAll();
-  WiFiClient::stopAll();
 
   if (_start_callback) {
     _start_callback();
diff --git a/libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h b/libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h
@@ -89,7 +89,6 @@ void ESP8266HTTPUpdateServerTemplate<ServerType>::setup(ESP8266WebServerTemplate
           return;
         }
 
-        WiFiUDP::stopAll();
         if (_serial_output)
           Serial.printf("Update: %s\n", upload.filename.c_str());
         if (upload.name == "filesystem") {
diff --git a/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp b/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp
@@ -224,7 +224,6 @@ void ESP8266WiFiGenericClass::_eventCallback(void* arg)
 
     if(event->event == EVENT_STAMODE_DISCONNECTED) {
         DEBUG_WIFI("STA disconnect: %d\n", event->event_info.disconnected.reason);
-        WiFiClient::stopAll();
     }
 
     if (event->event == EVENT_STAMODE_AUTHMODE_CHANGE) {

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,6 @@ void ESP8266HTTPUpdateServerTemplate<ServerType>::setup(ESP8266WebServerTemplate`
`89`	`89`	`return;`
`90`	`90`	`}`
`91`	`91`
`92`		`- WiFiUDP::stopAll();`
`93`	`92`	`if (_serial_output)`
`94`	`93`	`Serial.printf("Update: %s\n", upload.filename.c_str());`
`95`	`94`	`if (upload.name == "filesystem") {`
Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,6 @@ void ESP8266WiFiGenericClass::_eventCallback(void* arg)`
`224`	`224`
`225`	`225`	`if(event->event == EVENT_STAMODE_DISCONNECTED) {`
`226`	`226`	`DEBUG_WIFI("STA disconnect: %d\n", event->event_info.disconnected.reason);`
`227`		`- WiFiClient::stopAll();`
`228`	`227`	`}`
`229`	`228`
`230`	`229`	`if (event->event == EVENT_STAMODE_AUTHMODE_CHANGE) {`