bump go to v1.23, fix the metrics port hardcoding, fix the lint error in conditions.go

(cherry picked from commit 362eeeb)

Author: ibrokethecloud

Dockerfile.dapper

@@ -1,4 +1,4 @@
-FROM golang:1.22.7
+FROM golang:1.23
 
 ARG DAPPER_HOST_ARCH
 ENV ARCH $DAPPER_HOST_ARCH
@@ -15,7 +15,7 @@ RUN apt update && \
     apt install -y bash git gcc docker.io vim less file curl wget ca-certificates qemu-utils
 
 ## install golangci
-RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.59.1
+RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.63.4
 
 # The docker version in dapper is too old to have buildx. Install it manually.
 RUN curl -sSfL https://github.com/docker/buildx/releases/download/v0.13.1/buildx-v0.13.1.linux-${ARCH} -o buildx-v0.13.1.linux-${ARCH} && \

go.mod

@@ -1,6 +1,6 @@
 module github.com/harvester/seeder
 
-go 1.22.7
+go 1.23.4
 
 require (
 	github.com/go-bindata/go-bindata/v3 v3.1.3

pkg/controllers/setup.go

@@ -62,7 +62,7 @@ func (s *Server) Start(ctx context.Context) error {
 	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
 		Scheme: scheme,
 		Metrics: server.Options{
-			BindAddress: ":9080",
+			BindAddress: s.MetricsAddress,
 		},
 		HealthProbeBindAddress:  s.ProbeAddress,
 		LeaderElection:          s.EnableLeaderElection,

pkg/data/data.go

@@ -29,7 +29,7 @@ func CreateOrUpdateCondition(i *seederv1alpha1.Inventory, cond condition.Cond, m
 
 func SetErrorCondition(i *seederv1alpha1.Inventory, cond condition.Cond, message string) {
 	now := time.Now().UTC().Format(time.RFC3339)
-	cond.SetError(i, "", fmt.Errorf(message))
+	cond.SetError(i, "", fmt.Errorf("%s", message))
 	cond.True(i)
 	cond.LastUpdated(i, now)
 }