[assignment 2] Convert version route to plugin #44
Conversation
|
|
||
| // Register plugin | ||
| exports.register = function (server, options, next) { | ||
| server.route({ |
There was a problem hiding this comment.
newline after function
MylesBorins
force-pushed
the
assignment-2
branch
5 times, most recently
from
bb0485c to
462de95
Compare
| } | ||
| }); | ||
|
|
||
| next(); |
MylesBorins
force-pushed
the
assignment-2
branch
from
462de95 to
c0d9d04
Compare
|
Do we want to check if the version is a valid semver? |
|
@Sschuck the version comes from |
| var internals = {}; | ||
|
|
||
| var internals = { | ||
| version: require('./version') |
There was a problem hiding this comment.
This is odd. Just var Version = require('./version'); at the top and then use that in register().
MylesBorins
force-pushed
the
assignment-2
branch
2 times, most recently
from
8ae937a to
6961d7f
Compare
| @@ -2,35 +2,25 @@ | |||
|
|
|||
| var Hapi = require('hapi'); | |||
| var Hoek = require('hoek'); | |||
| var Package = require('../package.json'); | |||
|
|
|||
There was a problem hiding this comment.
In personal projects I have always put a new line between modules that are included from node_modules and modules that are being included locally from the project.
That aside the style has been fixed.
There was a problem hiding this comment.
I also like to do this, makes it easier to see what are local modules
There was a problem hiding this comment.
I just sort them: node, npm, local.
There was a problem hiding this comment.
Reasonable... I follow the same pattern (with spaces).
Thanks for taking the tie to discuss
There was a problem hiding this comment.
same sorting here only with newlines in between
MylesBorins
force-pushed
the
assignment-2
branch
from
6961d7f to
dc5005c
Compare
[assignment 2] Convert version route to plugin
Closes #43