Skip to content

Commit a069d95

Browse files
committed
feat(bb/import): use unique_ptr instead of raw pointers
1 parent 2d56fdc commit a069d95

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

src/import/bb/bb_importer.cpp

+2-7
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,16 @@ BBImporter::BBImporter(const string &file_name) {
88
std::ifstream f(file_name);
99
json data = json::parse(f);
1010

11-
bb_parser = new BBParser(data);
11+
bb_parser = make_unique<BBParser>(data);
1212
}
1313

1414
BBImporter::BBImporter(const string &file_name, string root_name) {
1515
std::ifstream f(file_name);
1616
json data = json::parse(f);
1717

18-
bb_parser = new BBParser(data, std::move(root_name));
18+
bb_parser = make_unique<BBParser>(data, std::move(root_name));
1919
}
2020

21-
BBImporter::~BBImporter() {
22-
delete bb_parser;
23-
}
24-
25-
2621
Model BBImporter::get_model() {
2722
return Model {
2823
bb_parser->get_model()

src/import/bb/bb_importer.h

+1-3
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,12 @@ class BBImporter : IArmatureImporter {
88
public:
99
explicit BBImporter(const string &file_name);
1010
explicit BBImporter(const string &file_name, string root_name);
11-
12-
~BBImporter();
1311

1412
Model get_model() override;
1513
Animation get_animation() override;
1614

1715
private:
18-
BBParser *bb_parser;
16+
unique_ptr<BBParser> bb_parser;
1917
};
2018

2119
#endif //MCMV_CORE_SRC_IMPORT_BB_BB_IMPORTER_H_

0 commit comments

Comments
 (0)