New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node.js 12 #20

Closed

gustavnikolaj opened this issue Sep 14, 2020 · 1 comment

Milestone

v5 major release

Owner

gustavnikolaj commented Sep 14, 2020 •

edited

Loading

Currently there is a single test failure on node 12:

  26 passing (258ms)
  1 failing

  1) hijackResponse
       #destroyHijacked
         should prevent hijackedRes from emitting more data:
     UnexpectedError:
expected { closeCalledCount: 2, emits: [] } to satisfy { closeCalledCount: 1, emits: [] }

{
  closeCalledCount: 2, // should equal 1
  emits: []
}

      at hijackresponse/test/hijackResponse.spec.js:327:16

This was the same error which was happening with the node 11 upgrade that got left hanging: #16

The text was updated successfully, but these errors were encountered:

This was referenced Sep 14, 2020

Supporting node.js v12 #21

Merged

Add support for node.js 14 #22

Closed

Owner Author

gustavnikolaj commented Sep 18, 2020

This was fixed as #21 was merged.

gustavnikolaj closed this as completed

gustavnikolaj added this to the v5 major release milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment