Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance by removing fallback search text generation #2395

Merged
merged 6 commits into from
Feb 22, 2025

Conversation

gunthercox
Copy link
Owner

This pull request makes a number of changes, the results of which should namely be:

  1. search_text and search_in_response_to values are now only generated when getting responses, and functionality to generate these values as a part of storage adapters, logic adapters, and other classes has been removed. This removed a number of unnecessary and inconsistent calls, and also opens up the ability for search text generation to be parallelized (in future pull requests).
  2. While making these changes I noticed a an inconsistency with the searching process in general that was resulting in text matches from not being found.

@gunthercox gunthercox merged commit 8339c6f into master Feb 22, 2025
4 checks passed
@gunthercox gunthercox deleted the search branch February 22, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant