Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotated & Signed Tags #2

Open
OliverEvans96 opened this issue May 2, 2020 · 3 comments
Open

Annotated & Signed Tags #2

OliverEvans96 opened this issue May 2, 2020 · 3 comments
Assignees

Comments

@OliverEvans96
Copy link
Contributor

Hi there,

Great package! It would be nice to have annotated and signed tags, which can be configured with go-git's CreateTagOptions.

Cheers,
Oliver

@guilhem
Copy link
Owner

guilhem commented May 4, 2020

What is the interface / behavior you may want?

@OliverEvans96
Copy link
Contributor Author

I think the optimal approach would be to mimic git tag with -a and -s flags

E.g., just run bump minor -a -m "tag message" or bump minor -s -m "tag message"

I specifically don't want to have to supply the path to my GPG key as a command line argument every time I want to do a signed tag bump.

Although it would be really nice to be able to just to do bump minor -s or bump minor -a and have an editor open according to the env var EDITOR, like git does to fill in the tag message. Although I'm not sure if this would be tricky - since go-get is a go reimplementation of git, I imagine you can't just let git tag -s open up the editor for you with the correct prompt.

@guilhem guilhem self-assigned this May 5, 2020
@fwkz
Copy link

fwkz commented Jun 10, 2020

I'd make the -m optional. The default value would be the version to which tag was bumped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants