Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Integration Tests #71

Closed
guibranco opened this issue Jul 24, 2023 · 6 comments
Closed

Add Integration Tests #71

guibranco opened this issue Jul 24, 2023 · 6 comments
Assignees
@Riju-bak
Labels
♻️ code quality Code quality-related tasks or issues enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed .NET Pull requests that update .net code 🧪 tests Tasks related to testing

Comments

@guibranco
Copy link
Owner

Add integration tests
@guibranco guibranco assigned guibranco and unassigned guibranco Jul 24, 2023
@guibranco guibranco added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers .NET Pull requests that update .net code ♻️ code quality Code quality-related tasks or issues 🧪 tests Tasks related to testing labels Jul 24, 2023
@Riju-bak
Copy link
Contributor

Riju-bak commented Jul 24, 2023 •
edited
Loading

Hi @guibranco, can I take it up?

@guibranco
Copy link
Owner Author

@Riju-bak yes, sure!

@Riju-bak
Copy link
Contributor

Riju-bak commented Jul 25, 2023 •
edited
Loading

@guibranco So I was thinking about how to organize the integration tests, and the following options come into mind -

  1. Create a separate project called ViaCep.IntegrationTests for the integration tests.
  2. Write all the integration tests within one file called IntegrationTests.cs inside the ViaCep.Tests project
  3. Write the integration tests inside ViaCep.Tests project itself but have separate test-files with names such as AddressIntegrationTests.cs and ZipCodeIntegrationTests.cs to make the type of the tests clear.

Which one do you think I must go for? If neither, then maybe you could tell me how you'd like to have them organized

@guibranco
Copy link
Owner Author

I prefer the first one, a separate project, so it`s possible to run it or not easily.

@Riju-bak Riju-bak mentioned this issue Jul 25, 2023
Merged
@guibranco
Copy link
Owner Author

@Riju-bak merged!
Nice job. Thanks for the effort!

@Riju-bak
Copy link
Contributor

@guibranco You're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Riju-bak Riju-bak

Labels
♻️ code quality Code quality-related tasks or issues enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed .NET Pull requests that update .net code 🧪 tests Tasks related to testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guibranco @Riju-bak