Add APIs prop to GuLambdaFunction #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengeller
force-pushed
the
sg-jl/google-chat-bots-migration
branch
from
e5a5c2d to
735e50d
Compare
added 2 commits
December 4, 2020 14:08
added 2 commits
December 4, 2020 17:02
…l/google-chat-bots-migration
akash1810
reviewed
Dec 4, 2020
| it("should create a lambda function with an api gateway", () => { | ||
| const stack = new Stack(); | ||
|
|
||
| new GuLambdaFunction(stack, "lambda", { |
There was a problem hiding this comment.
We probably want GuLambdaFunction to take in a GuStack as it's first argument, rather than a Construct as this will provide the stack and stage params and tags for free.
akash1810
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds a new
apisprop to theGuLambdaFunctionto which an array of config forLambdaRestApiscan be passed. This means that lambdas with an API gateway can be instantiated in one go.Does this change require changes to existing projects or CDK CLI?
This is a new, non-breaking feature so existing stacks won't require changes. Currently no migrated stacks make use of this feature but soon to be migrated stacks will.
How to test
A new snapshot has been added which includes the extra resources created when the
apisprop is used. Further testing can be done by migrating a stack that already uses lambdas and API gateway and verifying that the output is the same.How can we measure success?
Stacks which have api gateways along with lambda functions can specify them via the
apisprop for simpler configuration.Have we considered potential risks?
n/a
Images
n/a