Skip to content

Commit c6209fd

Browse files
gtwang01facebook-github-bot
authored andcommitted
Unpin gxx_linux-64 requirement (facebookresearch#3655)
Summary: The TestPartitioning.TestPartitioningBigRange test case fails on gcc version 13.2. We can avoid this by requiring gcc version 11.2 where the test case works. Pull Request resolved: facebookresearch#3655 Test Plan: STEP 1: Create conda env and install dependencies ``` conda create --name faiss_debug conda activate faiss_debug conda install -y -q python=3.11 cmake make swig mkl=2023 mkl-devel=2023 numpy scipy pytest gxx_linux-64 sysroot_linux-64 -c conda-forge ``` STEP 3: CMAKE ``` cmake -B build \ -DBUILD_TESTING=ON \ -DBUILD_SHARED_LIBS=ON \ -DFAISS_ENABLE_GPU=OFF \ -DFAISS_ENABLE_RAFT=OFF \ -DFAISS_OPT_LEVEL=avx2 \ -DFAISS_ENABLE_C_API=ON \ -DPYTHON_EXECUTABLE=$(which python) \ -DCMAKE_BUILD_TYPE=Release \ -DBLA_VENDOR=Intel10_64_dyn \ -DCMAKE_CUDA_FLAGS="-gencode arch=compute_75,code=sm_75" \ . ``` STEP 4: build ``` make -k -C build -j$(nproc) cd build ctest -R TestPartitioning.TestPartitioningBigRange ``` {F1769051341} Differential Revision: D59988036 Pulled By: gtwang01
1 parent 7178bf8 commit c6209fd

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- run:
3838
name: Install env using main channel
3939
command: |
40-
conda install -y -q python=3.11 cmake make swig mkl=2023 mkl-devel=2023 numpy scipy pytest gxx_linux-64=11.2 sysroot_linux-64
40+
conda install -y -q python=3.11 cmake make swig mkl=2023 mkl-devel=2023 numpy scipy pytest gxx_linux-64 sysroot_linux-64
4141
- run:
4242
name: Build all targets
4343
no_output_timeout: 30m

.github/actions/build_cmake/action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ runs:
3838
# install base packages for X86_64
3939
if [ "${{ runner.arch }}" = "X64" ]; then
4040
# TODO: unpin versions for gxx_linux-64 and sysroot_linux-64 and merge it with ARM64 below
41-
conda install -y -q -c conda-forge gxx_linux-64=11.2 sysroot_linux-64=2.28
41+
conda install -y -q -c conda-forge gxx_linux-64 sysroot_linux-64
4242
conda install -y -q mkl=2023 mkl-devel=2023
4343
fi
4444

.github/workflows/build.yml

-4
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ jobs:
164164
with:
165165
label: main
166166
cuda: "11.4.4"
167-
compiler_version: "11.2"
168167
linux-x86_64-GPU-RAFT-packages-CUDA11-8-0:
169168
name: Linux x86_64 GPU w/ RAFT packages (CUDA 11.8.0)
170169
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
@@ -182,7 +181,6 @@ jobs:
182181
label: main
183182
raft: "ON"
184183
cuda: "11.8.0"
185-
compiler_version: "11.2"
186184
linux-x86_64-GPU-packages-CUDA-12-1-1:
187185
name: Linux x86_64 GPU packages (CUDA 12.1.1)
188186
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
@@ -199,7 +197,6 @@ jobs:
199197
with:
200198
label: main
201199
cuda: "12.1.1"
202-
compiler_version: "11.2"
203200
linux-x86_64-GPU-RAFT-packages-CUDA12-1-1:
204201
name: Linux x86_64 GPU w/ RAFT packages (CUDA 12.1.1)
205202
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
@@ -217,7 +214,6 @@ jobs:
217214
label: main
218215
raft: "ON"
219216
cuda: "12.1.1"
220-
compiler_version: "11.2"
221217
windows-x86_64-packages:
222218
name: Windows x86_64 packages
223219
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')

0 commit comments

Comments
 (0)