Skip to content

Commit 89021ea

Browse files
gtwang01facebook-github-bot
authored andcommitted
Add gxx_linux-64 requirement (facebookresearch#3655)
Summary: The TestPartitioning.TestPartitioningBigRange test case fails on gcc version 13.2. We can avoid this by requiring gcc version 11.2 where the test case works. Pull Request resolved: facebookresearch#3655 Test Plan: STEP 1: Create conda env and install dependencies ``` conda create --name faiss_debug conda activate faiss_debug conda install -y -q python=3.11 cmake make swig mkl=2023 mkl-devel=2023 numpy scipy pytest gxx_linux-64 sysroot_linux-64 -c conda-forge ``` STEP 3: CMAKE ``` cmake -B build \ -DBUILD_TESTING=ON \ -DBUILD_SHARED_LIBS=ON \ -DFAISS_ENABLE_GPU=OFF \ -DFAISS_ENABLE_RAFT=OFF \ -DFAISS_OPT_LEVEL=avx2 \ -DFAISS_ENABLE_C_API=ON \ -DPYTHON_EXECUTABLE=$(which python) \ -DCMAKE_BUILD_TYPE=Release \ -DBLA_VENDOR=Intel10_64_dyn \ -DCMAKE_CUDA_FLAGS="-gencode arch=compute_75,code=sm_75" \ . ``` STEP 4: build ``` make -k -C build -j$(nproc) cd build ctest -R TestPartitioning.TestPartitioningBigRange ``` {F1769051341} Differential Revision: D59988036 Pulled By: gtwang01
1 parent 8b5895f commit 89021ea

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- run:
3838
name: Install env using main channel
3939
command: |
40-
conda install -y -q python=3.11 cmake make swig mkl=2023 mkl-devel=2023 numpy scipy pytest gxx_linux-64=11.2 sysroot_linux-64
40+
conda install -y -q python=3.11 cmake make swig mkl=2023 mkl-devel=2023 numpy scipy pytest gxx_linux-64 sysroot_linux-64
4141
- run:
4242
name: Build all targets
4343
no_output_timeout: 30m

.github/actions/build_cmake/action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ runs:
2929
echo "$CONDA/bin" >> $GITHUB_PATH
3030
3131
# install base packages
32-
conda install -y -q -c conda-forge gxx_linux-64=11.2 sysroot_linux-64=2.28
32+
conda install -y -q -c conda-forge gxx_linux-64 sysroot_linux-64
3333
conda install -y -q python=3.11 cmake make swig mkl=2023 mkl-devel=2023 numpy scipy pytest
3434
3535
# install CUDA packages

.github/workflows/build.yml

-4
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ jobs:
151151
with:
152152
label: main
153153
cuda: "11.4.4"
154-
compiler_version: "11.2"
155154
linux-x86_64-GPU-RAFT-packages-CUDA11-8-0:
156155
name: Linux x86_64 GPU w/ RAFT packages (CUDA 11.8.0)
157156
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
@@ -169,7 +168,6 @@ jobs:
169168
label: main
170169
raft: "ON"
171170
cuda: "11.8.0"
172-
compiler_version: "11.2"
173171
linux-x86_64-GPU-packages-CUDA-12-1-1:
174172
name: Linux x86_64 GPU packages (CUDA 12.1.1)
175173
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
@@ -186,7 +184,6 @@ jobs:
186184
with:
187185
label: main
188186
cuda: "12.1.1"
189-
compiler_version: "11.2"
190187
linux-x86_64-GPU-RAFT-packages-CUDA12-1-1:
191188
name: Linux x86_64 GPU w/ RAFT packages (CUDA 12.1.1)
192189
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
@@ -204,7 +201,6 @@ jobs:
204201
label: main
205202
raft: "ON"
206203
cuda: "12.1.1"
207-
compiler_version: "11.2"
208204
windows-x86_64-packages:
209205
name: Windows x86_64 packages
210206
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')

0 commit comments

Comments
 (0)