-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve regenerate.sh
to use the correct proto compiler version
#6583
Comments
I would like to contribute, can you please assign it to me |
@avinilcodes - Thanks! Note that most people on our team use both linux and macOS, so the script should be able to handle this properly on both systems, or at least fall back to the old behavior gracefully. |
Quick question: why not using the protoc binary from the fresh pull of protobuf repository? Wouldn't that solve the problem? We could then use Make, CMake or Bazel to generate the binary and replace all the protoc refs to the bin folder of protobuf. |
We don't want to always use the latest version because that would require updates to our generated code frequently. We have a release document that includes updating other dependencies that should update this one as well. But we'd like it to be a static version for now. |
@avinilcodes -- friendly ping |
This issue is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
hi @dfawley, can I pick this up? |
Similar to the other issue, @Aditya-Sood - LMK if you still want this. |
thank you Doug, as suggested I will close the other issue and then pick this up |
Currently the regenerate script installs
protoc-gen-go
andprotoc-gen-go-grpc
in a workdir, but uses the system installedprotoc
which means that running theregenerate.sh
script could result in all generated files being changed with a diff which would look something like:The text was updated successfully, but these errors were encountered: