Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many logs: [orca-backend-metrics] Missing ORCA load report #6423

Closed
YifeiZhuang opened this issue Jun 30, 2023 · 2 comments · Fixed by #6424
Closed

Too many logs: [orca-backend-metrics] Missing ORCA load report #6423

YifeiZhuang opened this issue Jun 30, 2023 · 2 comments · Fixed by #6424
Assignees

Comments

@YifeiZhuang
Copy link

The PSM test sees lots of [orca-backend-metrics] Missing ORCA load report spamming the Go client log, worth fixing.

b/288852233

client log link

@dfawley dfawley self-assigned this Jun 30, 2023
@dfawley
Copy link
Member

dfawley commented Jun 30, 2023

These only are logged when setting log verbosity to 2. Is this really a problem? Granted, the message itself isn't very helpful, so maybe that could be improved, but I'm inclined to not work too hard to reduce log messages at log verbosity of 2.

@dfawley
Copy link
Member

dfawley commented Jun 30, 2023

I don't actually see any way to improve this log statement..we can just delete it. But in general, reducing log spam at verbosity 2 shouldn't be considered a priority to address, as verbosity of 2 is for debugging, not general production use.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@YifeiZhuang @dfawley and others