Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path must be a string #19

Closed
geraldbaeck opened this issue May 24, 2016 · 5 comments
Closed

Path must be a string #19

geraldbaeck opened this issue May 24, 2016 · 5 comments

Comments

@geraldbaeck
Copy link

geraldbaeck commented May 24, 2016

I got this by running this script:

var selenium = require('selenium-download'); selenium.ensure('./bin', function(error) { if (error) { return callback(error); } });

[testium] grabbing selenium standalone server 2.43.0
path.js:7
throw new TypeError('Path must be a string. Received ' + inspect(path));
^

TypeError: Path must be a string. Received { url: 'http://selenium-release.storage.googleapis.com/2.43/selenium-server-standalone-2.43.0.jar',
name: 'selenium_2.43.0.jar' }
at assertPath (path.js:7:11)
at Object.basename (path.js:1355:5)
at /Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/node_modules/download/index.js:35:43
at each (/Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/node_modules/each-async/each-async.js:63:4)
at module.exports (/Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/node_modules/download/index.js:33:5)
at module.exports (/Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/lib/download.js:58:12)
at module.exports (/Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/lib/selenium/download.js:56:12)
at /Users/geraldback/Dropbox/dev/BäckBlog

@jkrems
Copy link
Contributor

jkrems commented May 24, 2016

@geraldbaeck Which version of node are you using? Is this node 6?

@geraldbaeck
Copy link
Author

geraldbaeck commented May 25, 2016

@jkrems v6.1.0

edit: It worked with v5.9.0

@arypurnomoz
Copy link

i also has this problem with node v6.2.1

@jkrems
Copy link
Contributor

jkrems commented Jul 27, 2016

Thanks for the report! That's what we get for waiting for LTS time until we properly test node versions. :) We'll look into fixing this in the near future but if anybody wants to get their hands dirty on this, we'd definitely accept PRs.

@jkrems
Copy link
Contributor

jkrems commented Jul 27, 2016

Actually, this repo was due for a JavaScript conversion anyhow. #27

@jkrems jkrems closed this as completed in 861da47 Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants