Merge branch 'devel'

Author: grindsa

CHANGES.md

@@ -3,7 +3,13 @@
 
 This is a high-level summary of the most important changes. For a full list of changes, see the [git commit log](https://github.com/grindsa/dkb-robo/commits) and pick the appropriate release branch.
 
-# Changes in 0.29-3
+# Changes in 0.29.4
+
+**Bugfixes**:
+
+- [#80](https://github.com/grindsa/dkb-robo/issues/80) - Download documents without date field in metadata
+
+# Changes in 0.29.3
 
 **Bugfixes**:
 

dkb_robo/postbox.py

@@ -150,7 +150,11 @@ def date(self) -> str:
             date = datetime.date.fromisoformat(self.document.metadata['creationDate'])
 
         if date is None:
-            raise AttributeError("No valid date field found in document metadata.")
+            if 'subject' in self.document.metadata:
+                logger.error("\"%s\" is missing a valid date field found in metadata. Using today\'s date as fallback.", self.document.metadata['subject'])
+            else:
+                logger.error("No valid date field found in document metadata. Using today's date as fallback.")
+            date = datetime.date.today()
 
         logger.debug("PostboxItem.date() for document %s ended with %s", self.id, date)
         return date.strftime('%Y-%m-%d')

pyproject.toml

@@ -3,7 +3,7 @@ authors = [{ name = "grindsa", email = "grindelsack@gmail.com" }]
 name = "dkb_robo"
 description = "Download transactions from the website of Deutsche Kreditbak AG"
 keywords = ["Deutsche Kreditbank", "DKB"]
-version = "0.29.3"
+version = "0.29.4"
 readme = "README.md"
 classifiers = [
     # Keep in sync with the Python version matrix in test_lint.yaml GitHub workflow.

test/test_postbox.py

@@ -4,7 +4,7 @@
 import unittest
 from unittest.mock import patch, MagicMock
 from pathlib import Path
-
+from datetime import date
 import requests
 import logging
 sys.path.insert(0, '.')
@@ -198,12 +198,23 @@ def test_022_date_with_creation_date(self):
         self.document.metadata = {"creationDate": "2023-01-01"}
         self.assertEqual(self.postbox_item.date(), "2023-01-01")
 
-    def test_023_date_invalid(self):
+    @patch("dkb_robo.postbox.datetime.date")
+    def test_023_date_invalid(self, mock_today):
         """ Test that the date method raises an exception if no valid date field is found in the metadata."""
         self.document.metadata = {}
-        with self.assertRaises(AttributeError):
-            self.postbox_item.date()
+        mock_today.today.return_value = date(2025, 3, 23)
+        with self.assertLogs('dkb_robo', level='INFO') as lcm:
+            self.assertEqual('2025-03-23', self.postbox_item.date())
+        self.assertIn("ERROR:dkb_robo.postbox:No valid date field found in document metadata. Using today's date as fallback.", lcm.output)
 
+    @patch("dkb_robo.postbox.datetime.date")
+    def test_024_date_invalid(self, mock_today):
+        """ Test that the date method raises an exception if no valid date field is found in the metadata."""
+        self.document.metadata = {"subject": "subject"}
+        mock_today.today.return_value = date(2025, 3, 23)
+        with self.assertLogs('dkb_robo', level='INFO') as lcm:
+            self.assertEqual('2025-03-23', self.postbox_item.date())
+        self.assertIn('ERROR:dkb_robo.postbox:"subject" is missing a valid date field found in metadata. Using today\'s date as fallback.', lcm.output)
 
 class TestPostBox(unittest.TestCase):
     """ Tests for the PostBox class. """